Add "add immediate" instruction to the ARM integrated assembler.

Add "add immediate" instruction to the ARM integrated assembler.

Also does some bikeshed clean ups. In particualr, the (ARM)
instruction method emitIAS only needs to choose the applicable ARM
instruction, and then passes the corresponding operands to the
corresponding instruction method of the assembler. The assembler
method then extracts the appropriate data from the operands, and
decides which rule to apply for the corresponding arm instruction.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=372bdd6e84a14b6bcc00b4e9ed24a1838bd0c4d7

[Karl, 2015-10-13 21:19:25]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, stichnot@chromium.org

[John, 2015-10-13 21:27:56]

lgtm

please add the TODO(jpp). Lgtm otherwise.

https://chromiumcodereview.appspot.com/1407613002/diff/20001/src/IceInstARM32...
File src/IceInstARM32.cpp (right):

https://chromiumcodereview.appspot.com/1407613002/diff/20001/src/IceInstARM32...
src/IceInstARM32.cpp:322: void InstARM32ThreeAddrGPR<K>::emitIAS(const Cfg
*Func) const {
I am not super exited about these definitions here. Can you leave a TODO(jpp) so
that I (in the near future) figure out how to move these out of this .h?

[Jim Stichnoth, 2015-10-13 21:28:52]

lgtm

https://chromiumcodereview.appspot.com/1407613002/diff/20001/src/IceAssembler...
File src/IceAssemblerARM32.cpp (right):

https://chromiumcodereview.appspot.com/1407613002/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.cpp:84: DecodedResult decode(const Ice::Operand *Operand,
uint32_t &Value) {
Can you use Operand instead of Ice::Operand?

Also, maybe rename the arg Opnd instead of Operand to avoid a name conflict.

[Karl, 2015-10-13 21:39:18]

Committed patchset #3 (id:40001) manually as
372bdd6e84a14b6bcc00b4e9ed24a1838bd0c4d7 (presubmit successful).

[Karl, 2015-10-13 21:39:25]

https://chromiumcodereview.appspot.com/1407613002/diff/20001/src/IceAssembler...
File src/IceAssemblerARM32.cpp (right):

https://chromiumcodereview.appspot.com/1407613002/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.cpp:84: DecodedResult decode(const Ice::Operand *Operand,
uint32_t &Value) {
On 2015/10/13 21:28:52, stichnot wrote:
> Can you use Operand instead of Ice::Operand?
> 
> Also, maybe rename the arg Opnd instead of Operand to avoid a name conflict.

Done.

https://chromiumcodereview.appspot.com/1407613002/diff/20001/src/IceInstARM32...
File src/IceInstARM32.cpp (right):

https://chromiumcodereview.appspot.com/1407613002/diff/20001/src/IceInstARM32...
src/IceInstARM32.cpp:322: void InstARM32ThreeAddrGPR<K>::emitIAS(const Cfg
*Func) const {
On 2015/10/13 21:27:56, John wrote:
> I am not super exited about these definitions here. Can you leave a TODO(jpp)
so
> that I (in the near future) figure out how to move these out of this .h?

This is in a .cpp file!