Issue 1407523002: Rename gl2mojo.h to gl2mojo_internal.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1407523002: Rename gl2mojo.h to gl2mojo_internal.h. (Closed)

Created:
5 years, 2 months ago by viettrungluu

Modified:
5 years, 2 months ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Rename gl2mojo.h to gl2mojo_internal.h. This header isn't meant to be included by consumers (the correct thing to do is to just include <GLES2/gl2.h>, which includes this file). This is unlike gl2extmojo.h, which *is* meant for public consumption. Arguably, I should also rename gl2mojo_autogen.h to gl2mojo_internal_autogen.h, but that's probably overkill (also, I'm lazy). Also update BUILD.gn to have all the files. (The slight source change is due to clang formatting changes.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f3eda8c42e7d26c733fb8a3508d002608b406196

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -39 lines)			Patch
M	mojo/public/c/gpu/BUILD.gn	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	mojo/public/c/gpu/GLES2/gl2.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	mojo/public/c/gpu/GLES2/gl2mojo.h	View	1 chunk	+0 lines, -32 lines	0 comments	Download
A +	mojo/public/c/gpu/GLES2/gl2mojo_internal.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 2 months ago (2015-10-13 19:50:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f3eda8c42e7d26c733fb8a3508d002608b406196 (presubmit successful).

Expand Messages | Collapse Messages