Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: build/common.gypi

Issue 1407433005: Enable /Zc:StrictStrings on release builds Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix formatting Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_installer_util.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 944dcb6eebb257bf06dda0140bcd09e45face065..d64aabeee951ffcef5171678454cfe741d618a31 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2882,6 +2882,9 @@
'NTDDI_VERSION=0x06030000',
# This is required for ATL to use XP-safe versions of its functions.
'_USING_V110_SDK71_',
+ # This is required to avoid including mshtml.h, which is wasteful
+ # and not StrictStrings compliant.
+ '_ATL_NO_HOSTING'
],
'include_dirs': [
'<(DEPTH)/third_party/wtl/include',
@@ -3531,6 +3534,8 @@
'AdditionalOptions': [
'/d2Zi+', # Improve debugging of Release builds.
'/Zc:inline', # Remove unreferenced COMDAT (faster links).
+ # Prohibit assigning string constants to non-const char*
+ '/Zc:strictStrings',
'<@(win_release_extra_cflags)',
],
},
« no previous file with comments | « no previous file | chrome/chrome_installer_util.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698