Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: chrome/chrome_installer_util.gypi

Issue 1407433005: Enable /Zc:StrictStrings on release builds Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix formatting Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_installer_util.gypi
diff --git a/chrome/chrome_installer_util.gypi b/chrome/chrome_installer_util.gypi
index f0928a44debb68598e759ce05b95204bf5167f5d..034322d3f2ebea0e89ac860f0999cbdbc5cc229a 100644
--- a/chrome/chrome_installer_util.gypi
+++ b/chrome/chrome_installer_util.gypi
@@ -7,6 +7,19 @@
'variables': {
'installer_util_target': 0,
},
+ 'conditions': [
+ ['OS=="win"', {
+ # As of the Windows 10 SDK WbemDisp.h still contains many function
+ # prototypes with BSTR strObjectPath = L"" which /Zc:StrictStrings
+ # rightly rejects, and WbemDisp.h is required by some chrome installer
+ # components.
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions!': [ '/Zc:strictStrings' ]
+ },
+ },
+ }],
+ ],
'target_conditions': [
# This part is shared between the two versions of the target.
['installer_util_target==1', {
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698