Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: build/common.gypi

Issue 1407433005: Enable /Zc:StrictStrings on release builds Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix formatting Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/chrome_installer_util.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2864 matching lines...) Expand 10 before | Expand all | Expand 10 after
2875 ['OS=="win"', { 2875 ['OS=="win"', {
2876 'defines': [ 2876 'defines': [
2877 '__STD_C', 2877 '__STD_C',
2878 '_CRT_SECURE_NO_DEPRECATE', 2878 '_CRT_SECURE_NO_DEPRECATE',
2879 '_SCL_SECURE_NO_DEPRECATE', 2879 '_SCL_SECURE_NO_DEPRECATE',
2880 # This define is required to pull in the new Win8 interfaces from 2880 # This define is required to pull in the new Win8 interfaces from
2881 # system headers like ShObjIdl.h. 2881 # system headers like ShObjIdl.h.
2882 'NTDDI_VERSION=0x06030000', 2882 'NTDDI_VERSION=0x06030000',
2883 # This is required for ATL to use XP-safe versions of its functions. 2883 # This is required for ATL to use XP-safe versions of its functions.
2884 '_USING_V110_SDK71_', 2884 '_USING_V110_SDK71_',
2885 # This is required to avoid including mshtml.h, which is wasteful
2886 # and not StrictStrings compliant.
2887 '_ATL_NO_HOSTING'
2885 ], 2888 ],
2886 'include_dirs': [ 2889 'include_dirs': [
2887 '<(DEPTH)/third_party/wtl/include', 2890 '<(DEPTH)/third_party/wtl/include',
2888 ], 2891 ],
2889 'conditions': [ 2892 'conditions': [
2890 ['win_z7!=0', { 2893 ['win_z7!=0', {
2891 'msvs_settings': { 2894 'msvs_settings': {
2892 # Generates debug info when win_z7=1 2895 # Generates debug info when win_z7=1
2893 # even if fastbuild=1 (that makes GenerateDebugInformation false). 2896 # even if fastbuild=1 (that makes GenerateDebugInformation false).
2894 'VCLinkerTool': { 2897 'VCLinkerTool': {
(...skipping 629 matching lines...) Expand 10 before | Expand all | Expand 10 after
3524 # to put bit-identical constants at the same address even if 3527 # to put bit-identical constants at the same address even if
3525 # they're unrelated constants, which saves binary size. 3528 # they're unrelated constants, which saves binary size.
3526 # This optimization can't be used when ASan is enabled because 3529 # This optimization can't be used when ASan is enabled because
3527 # it is not compatible with the ASan ODR checker. 3530 # it is not compatible with the ASan ODR checker.
3528 'AdditionalOptions': ['/Gw'], 3531 'AdditionalOptions': ['/Gw'],
3529 }], 3532 }],
3530 ], 3533 ],
3531 'AdditionalOptions': [ 3534 'AdditionalOptions': [
3532 '/d2Zi+', # Improve debugging of Release builds. 3535 '/d2Zi+', # Improve debugging of Release builds.
3533 '/Zc:inline', # Remove unreferenced COMDAT (faster links). 3536 '/Zc:inline', # Remove unreferenced COMDAT (faster links).
3537 # Prohibit assigning string constants to non-const char*
3538 '/Zc:strictStrings',
3534 '<@(win_release_extra_cflags)', 3539 '<@(win_release_extra_cflags)',
3535 ], 3540 ],
3536 }, 3541 },
3537 'VCLinkerTool': { 3542 'VCLinkerTool': {
3538 # LinkIncremental is a tri-state boolean, where 0 means default 3543 # LinkIncremental is a tri-state boolean, where 0 means default
3539 # (i.e., inherit from parent solution), 1 means false, and 3544 # (i.e., inherit from parent solution), 1 means false, and
3540 # 2 means true. 3545 # 2 means true.
3541 'LinkIncremental': '1', 3546 'LinkIncremental': '1',
3542 # This corresponds to the /PROFILE flag which ensures the PDB 3547 # This corresponds to the /PROFILE flag which ensures the PDB
3543 # file contains FIXUP information (growing the PDB file by about 3548 # file contains FIXUP information (growing the PDB file by about
(...skipping 2753 matching lines...) Expand 10 before | Expand all | Expand 10 after
6297 # settings in target dicts. SYMROOT is a special case, because many other 6302 # settings in target dicts. SYMROOT is a special case, because many other
6298 # Xcode variables depend on it, including variables such as 6303 # Xcode variables depend on it, including variables such as
6299 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6304 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6300 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6305 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6301 # files to appear (when present) in the UI as actual files and not red 6306 # files to appear (when present) in the UI as actual files and not red
6302 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6307 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6303 # and therefore SYMROOT, needs to be set at the project level. 6308 # and therefore SYMROOT, needs to be set at the project level.
6304 'SYMROOT': '<(DEPTH)/xcodebuild', 6309 'SYMROOT': '<(DEPTH)/xcodebuild',
6305 }, 6310 },
6306 } 6311 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_installer_util.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698