Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1407433005: Enable /Zc:StrictStrings on release builds

Created:
5 years, 2 months ago by brucedawson
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable /Zc:StrictStrings on release builds This change gets most of Chromium building with /Zc:StrictStrings. It turns the option on globally and defines _ATL_NO_HOSTING to avoid pulling in mshtml.h (not StrictStrings compliant) and then turns it off for installer_util_target which needs WbdemDisp.h which is also not StrictStrings compliant. Unfortunately that is not sufficient since there are two more source files that need mshtml.h leading to these failures that are too painful to fix: ninja: Entering directory `out\Release' [1/30 - 3% 0.000] CXX obj\remoting\host\win\remoting_host.rdp_client_window.obj d:\src\chromium\src\remoting\host\win\rdp_client_window.cc(237): error C2065: 'CAxWindow2': undeclared identifier [2/30 - 6% 0.000] CXX obj\remoting\host\win\remoting_unittests.rdp_client_unittest.obj c:\src\depot_tools\win_toolchain\vs_files\win_sdk\include\um\mshtml.h(16561): error C2440: 'default argument': cannot convert from 'const wchar_t [1]' to 'BSTR' It's not worth proceeding because no actual Chromium bugs were found.

Patch Set 1 #

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M build/common.gypi View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 1 chunk +13 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698