Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 1407393006: Make arm assembler explicitly take both registers for load/store-pair. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_arm.cc
diff --git a/runtime/vm/intrinsifier_arm.cc b/runtime/vm/intrinsifier_arm.cc
index dd6d509c34940a0085a1c23846dc065b52974d0d..f4cbb6a47d33dc77a3c2d5cddd9e5cce032c6fc6 100644
--- a/runtime/vm/intrinsifier_arm.cc
+++ b/runtime/vm/intrinsifier_arm.cc
@@ -225,7 +225,7 @@ void Intrinsifier::GrowableArray_add(Assembler* assembler) {
__ Bind(&init_loop); \
__ AddImmediate(R3, 2 * kWordSize); \
__ cmp(R3, Operand(R1)); \
- __ strd(R6, R3, -2 * kWordSize, LS); \
+ __ strd(R6, R7, R3, -2 * kWordSize, LS); \
__ b(&init_loop, CC); \
__ str(R6, Address(R3, -2 * kWordSize), HI); \
\
@@ -769,9 +769,9 @@ void Intrinsifier::Bigint_lsh(Assembler* assembler) {
// Uint32List r_digits)
// R2 = x_used, R3 = x_digits, x_used > 0, x_used is Smi.
- __ ldrd(R2, SP, 2 * kWordSize);
+ __ ldrd(R2, R3, SP, 2 * kWordSize);
// R4 = r_digits, R5 = n, n is Smi, n % _DIGIT_BITS != 0.
- __ ldrd(R4, SP, 0 * kWordSize);
+ __ ldrd(R4, R5, SP, 0 * kWordSize);
__ SmiUntag(R5);
// R0 = n ~/ _DIGIT_BITS
__ Asr(R0, R5, Operand(5));
@@ -809,9 +809,9 @@ void Intrinsifier::Bigint_rsh(Assembler* assembler) {
// Uint32List r_digits)
// R2 = x_used, R3 = x_digits, x_used > 0, x_used is Smi.
- __ ldrd(R2, SP, 2 * kWordSize);
+ __ ldrd(R2, R3, SP, 2 * kWordSize);
// R4 = r_digits, R5 = n, n is Smi, n % _DIGIT_BITS != 0.
- __ ldrd(R4, SP, 0 * kWordSize);
+ __ ldrd(R4, R5, SP, 0 * kWordSize);
__ SmiUntag(R5);
// R0 = n ~/ _DIGIT_BITS
__ Asr(R0, R5, Operand(5));
@@ -854,12 +854,12 @@ void Intrinsifier::Bigint_absAdd(Assembler* assembler) {
// Uint32List r_digits)
// R2 = used, R3 = digits
- __ ldrd(R2, SP, 3 * kWordSize);
+ __ ldrd(R2, R3, SP, 3 * kWordSize);
// R3 = &digits[0]
__ add(R3, R3, Operand(TypedData::data_offset() - kHeapObjectTag));
// R4 = a_used, R5 = a_digits
- __ ldrd(R4, SP, 1 * kWordSize);
+ __ ldrd(R4, R5, SP, 1 * kWordSize);
// R5 = &a_digits[0]
__ add(R5, R5, Operand(TypedData::data_offset() - kHeapObjectTag));
@@ -914,12 +914,12 @@ void Intrinsifier::Bigint_absSub(Assembler* assembler) {
// Uint32List r_digits)
// R2 = used, R3 = digits
- __ ldrd(R2, SP, 3 * kWordSize);
+ __ ldrd(R2, R3, SP, 3 * kWordSize);
// R3 = &digits[0]
__ add(R3, R3, Operand(TypedData::data_offset() - kHeapObjectTag));
// R4 = a_used, R5 = a_digits
- __ ldrd(R4, SP, 1 * kWordSize);
+ __ ldrd(R4, R5, SP, 1 * kWordSize);
// R5 = &a_digits[0]
__ add(R5, R5, Operand(TypedData::data_offset() - kHeapObjectTag));
@@ -994,7 +994,7 @@ void Intrinsifier::Bigint_mulAdd(Assembler* assembler) {
Label done;
// R3 = x, no_op if x == 0
- __ ldrd(R0, SP, 5 * kWordSize); // R0 = xi as Smi, R1 = x_digits.
+ __ ldrd(R0, R1, SP, 5 * kWordSize); // R0 = xi as Smi, R1 = x_digits.
__ add(R1, R1, Operand(R0, LSL, 1));
__ ldr(R3, FieldAddress(R1, TypedData::data_offset()));
__ tst(R3, Operand(R3));
@@ -1006,12 +1006,12 @@ void Intrinsifier::Bigint_mulAdd(Assembler* assembler) {
__ b(&done, EQ);
// R4 = mip = &m_digits[i >> 1]
- __ ldrd(R0, SP, 3 * kWordSize); // R0 = i as Smi, R1 = m_digits.
+ __ ldrd(R0, R1, SP, 3 * kWordSize); // R0 = i as Smi, R1 = m_digits.
__ add(R1, R1, Operand(R0, LSL, 1));
__ add(R4, R1, Operand(TypedData::data_offset() - kHeapObjectTag));
// R5 = ajp = &a_digits[j >> 1]
- __ ldrd(R0, SP, 1 * kWordSize); // R0 = j as Smi, R1 = a_digits.
+ __ ldrd(R0, R1, SP, 1 * kWordSize); // R0 = j as Smi, R1 = a_digits.
__ add(R1, R1, Operand(R0, LSL, 1));
__ add(R5, R1, Operand(TypedData::data_offset() - kHeapObjectTag));
@@ -1094,7 +1094,7 @@ void Intrinsifier::Bigint_sqrAdd(Assembler* assembler) {
// }
// R4 = xip = &x_digits[i >> 1]
- __ ldrd(R2, SP, 2 * kWordSize); // R2 = i as Smi, R3 = x_digits
+ __ ldrd(R2, R3, SP, 2 * kWordSize); // R2 = i as Smi, R3 = x_digits
__ add(R3, R3, Operand(R2, LSL, 1));
__ add(R4, R3, Operand(TypedData::data_offset() - kHeapObjectTag));
@@ -1172,7 +1172,7 @@ void Intrinsifier::Bigint_sqrAdd(Assembler* assembler) {
// *ajp = low32(t) = R6
// *(ajp + 1) = high32(t) = R7
- __ strd(R6, R5, 0);
+ __ strd(R6, R7, R5, 0);
__ Bind(&x_zero);
__ mov(R0, Operand(Smi::RawValue(1))); // One digit processed.
@@ -1203,7 +1203,7 @@ void Intrinsifier::Montgomery_mulMod(Assembler* assembler) {
TypedData::data_offset() + 2*Bigint::kBytesPerDigit));
// R2 = digits[i >> 1]
- __ ldrd(R0, SP, 0 * kWordSize); // R0 = i as Smi, R1 = digits
+ __ ldrd(R0, R1, SP, 0 * kWordSize); // R0 = i as Smi, R1 = digits
__ add(R1, R1, Operand(R0, LSL, 1));
__ ldr(R2, FieldAddress(R1, TypedData::data_offset()));
« no previous file with comments | « runtime/vm/assembler_arm_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698