runtime/vm/assembler_arm_test.cc - Issue 1407393006: Make arm assembler explicitly take both registers for load/store-pair.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm_test.cc

Issue 1407393006: Make arm assembler explicitly take both registers for load/store-pair. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_arm_test.cc

diff --git a/runtime/vm/assembler_arm_test.cc b/runtime/vm/assembler_arm_test.cc

index dd532353f2bd6e8d0368ab4776a69cbc2dd5a280..6eafd9c460c0e9ca91d282bb08fee428cb8b20fb 100644

--- a/runtime/vm/assembler_arm_test.cc

+++ b/runtime/vm/assembler_arm_test.cc

@@ -1150,10 +1150,10 @@ ASSEMBLER_TEST_RUN(Ldrh1, test) {

ASSEMBLER_TEST_GENERATE(Ldrd, assembler) {

__ mov(IP, Operand(SP));

__ sub(SP, SP, Operand(kWordSize*30));

- __ strd(R2, SP, 0);

- __ strd(R0, IP, (-kWordSize*28));

- __ ldrd(R2, IP, (-kWordSize*28));

- __ ldrd(R0, SP, 0);

+ __ strd(R2, R3, SP, 0);

+ __ strd(R0, R1, IP, (-kWordSize*28));

+ __ ldrd(R2, R3, IP, (-kWordSize*28));

+ __ ldrd(R0, R1, SP, 0);

__ add(SP, SP, Operand(kWordSize*30));

__ sub(R0, R0, Operand(R2));

__ add(R1, R1, Operand(R3));

« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/intrinsifier_arm.cc » ('j') | no next file with comments »