Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 1407363010: Make table in chrome:site-engagement sortable. (Closed)

Created:
5 years, 1 month ago by calamity
Modified:
5 years, 1 month ago
Reviewers:
tsergeant, Dan Beam
CC:
Aaron Boodman, abarth-chromium, arv+watch_chromium.org, ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make table in chrome:site-engagement sortable. This CL makes the site engagement table sortable when the table header column is clicked. It also makes the values in the table round to 2 decimal places rather than truncating to an int. BUG=524857 Committed: https://crrev.com/96cbae9321d95c2310c2b4981d9359ce970d83e6 Cr-Commit-Position: refs/heads/master@{#357314}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Total comments: 4

Patch Set 3 : address comments #

Total comments: 14

Patch Set 4 : address comments #

Total comments: 4

Patch Set 5 : add @returns #

Patch Set 6 : go back to normal functions to please the almighty PRESUBMIT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -10 lines) Patch
M chrome/browser/resources/engagement/engagement_table.css View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/engagement/engagement_table.html View 1 2 3 1 chunk +9 lines, -3 lines 0 comments Download
M chrome/browser/resources/engagement/engagement_table.js View 1 2 3 4 5 2 chunks +91 lines, -4 lines 0 comments Download
M chrome/browser/resources/engagement/site_engagement.js View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/engagement/site_engagement.mojom View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/engagement/site_engagement_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (7 generated)
calamity
5 years, 1 month ago (2015-10-27 08:02:50 UTC) #2
tsergeant
Generally looks good. I've made a couple of suggestions to use a bit more of ...
5 years, 1 month ago (2015-10-27 23:35:34 UTC) #3
calamity
https://codereview.chromium.org/1407363010/diff/1/chrome/browser/resources/engagement/engagement_table.html File chrome/browser/resources/engagement/engagement_table.html (right): https://codereview.chromium.org/1407363010/diff/1/chrome/browser/resources/engagement/engagement_table.html#newcode9 chrome/browser/resources/engagement/engagement_table.html:9: <th id="initial-sort-column" on-tap="handleSortColumnTap" sort-key="origin">Origin</th> On 2015/10/27 23:35:34, tsergeant wrote: ...
5 years, 1 month ago (2015-10-28 04:26:50 UTC) #4
tsergeant
https://codereview.chromium.org/1407363010/diff/20001/chrome/browser/resources/engagement/engagement_table.html File chrome/browser/resources/engagement/engagement_table.html (right): https://codereview.chromium.org/1407363010/diff/20001/chrome/browser/resources/engagement/engagement_table.html#newcode18 chrome/browser/resources/engagement/engagement_table.html:18: <template id="engagement-table-items" is="dom-repeat" items="{{engagementInfo}}" as="info" sort="[[getTableSortFunction_(sortKey_, sortReverse_)]]"> Nit: wrap ...
5 years, 1 month ago (2015-10-28 04:57:03 UTC) #5
calamity
https://codereview.chromium.org/1407363010/diff/20001/chrome/browser/resources/engagement/engagement_table.html File chrome/browser/resources/engagement/engagement_table.html (right): https://codereview.chromium.org/1407363010/diff/20001/chrome/browser/resources/engagement/engagement_table.html#newcode18 chrome/browser/resources/engagement/engagement_table.html:18: <template id="engagement-table-items" is="dom-repeat" items="{{engagementInfo}}" as="info" sort="[[getTableSortFunction_(sortKey_, sortReverse_)]]"> On 2015/10/28 ...
5 years, 1 month ago (2015-10-28 05:43:11 UTC) #6
tsergeant
lgtm
5 years, 1 month ago (2015-10-28 22:28:54 UTC) #7
calamity
+dbeam for c/b/ui/webui OWNERS.
5 years, 1 month ago (2015-10-29 00:30:37 UTC) #9
Dan Beam
sorry, but I had to look https://codereview.chromium.org/1407363010/diff/40001/chrome/browser/resources/engagement/engagement_table.css File chrome/browser/resources/engagement/engagement_table.css (right): https://codereview.chromium.org/1407363010/diff/40001/chrome/browser/resources/engagement/engagement_table.css#newcode31 chrome/browser/resources/engagement/engagement_table.css:31: content: '\25B2'; any ...
5 years, 1 month ago (2015-10-29 00:50:01 UTC) #10
calamity
Thanks for the review! https://codereview.chromium.org/1407363010/diff/40001/chrome/browser/resources/engagement/engagement_table.css File chrome/browser/resources/engagement/engagement_table.css (right): https://codereview.chromium.org/1407363010/diff/40001/chrome/browser/resources/engagement/engagement_table.css#newcode31 chrome/browser/resources/engagement/engagement_table.css:31: content: '\25B2'; On 2015/10/29 00:50:00, ...
5 years, 1 month ago (2015-10-29 02:46:01 UTC) #11
Dan Beam
lgtm https://codereview.chromium.org/1407363010/diff/60001/chrome/browser/resources/engagement/engagement_table.js File chrome/browser/resources/engagement/engagement_table.js (right): https://codereview.chromium.org/1407363010/diff/60001/chrome/browser/resources/engagement/engagement_table.js#newcode10 chrome/browser/resources/engagement/engagement_table.js:10: */ @return https://codereview.chromium.org/1407363010/diff/60001/chrome/browser/resources/engagement/engagement_table.js#newcode87 chrome/browser/resources/engagement/engagement_table.js:87: * @param {string} sortKey ...
5 years, 1 month ago (2015-10-29 22:03:16 UTC) #12
calamity
https://codereview.chromium.org/1407363010/diff/60001/chrome/browser/resources/engagement/engagement_table.js File chrome/browser/resources/engagement/engagement_table.js (right): https://codereview.chromium.org/1407363010/diff/60001/chrome/browser/resources/engagement/engagement_table.js#newcode10 chrome/browser/resources/engagement/engagement_table.js:10: */ On 2015/10/29 22:03:16, Dan Beam wrote: > @return ...
5 years, 1 month ago (2015-10-30 03:56:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407363010/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407363010/80001
5 years, 1 month ago (2015-10-30 05:06:37 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/114221)
5 years, 1 month ago (2015-10-30 05:13:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407363010/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407363010/100001
5 years, 1 month ago (2015-11-02 06:22:25 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 1 month ago (2015-11-02 06:26:30 UTC) #22
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 06:27:29 UTC) #23
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/96cbae9321d95c2310c2b4981d9359ce970d83e6
Cr-Commit-Position: refs/heads/master@{#357314}

Powered by Google App Engine
This is Rietveld 408576698