chrome/browser/resources/engagement/site_engagement.js - Issue 1407363010: Make table in chrome:site-engagement sortable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/engagement/site_engagement.js

Issue 1407363010: Make table in chrome:site-engagement sortable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: go back to normal functions to please the almighty PRESUBMIT Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/engagement/site_engagement.js

diff --git a/chrome/browser/resources/engagement/site_engagement.js b/chrome/browser/resources/engagement/site_engagement.js

index 911bbe594327e637ba3ff6014655587d7cc15f6e..22cef9c1183daf28520f3a5b20fe46a981b367da 100644

--- a/chrome/browser/resources/engagement/site_engagement.js

+++ b/chrome/browser/resources/engagement/site_engagement.js

@@ -17,7 +17,11 @@ define('main', [

siteEngagementMojom.SiteEngagementUIHandler);

// Populate engagement table.

- uiHandler.getSiteEngagementInfo().then(response => {

+ uiHandler.getSiteEngagementInfo().then(function(response) {

+ // Round each score to 2 decimal places.

+ response.info.forEach(function(x) {

+ x.score = Number(Math.round(x.score * 100) / 100);

+ });

$('engagement-table').engagementInfo = response.info;

});

};