Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Side by Side Diff: chrome/browser/resources/engagement/engagement_table.html

Issue 1407363010: Make table in chrome:site-engagement sortable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: go back to normal functions to please the almighty PRESUBMIT Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 2
3 <dom-module id="engagement-table"> 3 <dom-module id="engagement-table">
4 <link rel="import" type="css" href="engagement_table.css"> 4 <link rel="import" type="css" href="engagement_table.css">
5 <template> 5 <template>
6 <table> 6 <table>
7 <thead> 7 <thead>
8 <tr> 8 <tr>
9 <th>Origin</th> 9 <th on-tap="handleSortColumnTap" sort-key="origin">
10 <th>Points</th> 10 Origin
11 </th>
12 <th on-tap="handleSortColumnTap" sort-key="score" class="sort-column">
13 Points
14 </th>
11 </tr> 15 </tr>
12 </thead> 16 </thead>
13 <tbody> 17 <tbody>
14 <template is="dom-repeat" items="{{engagementInfo}}" as="info"> 18 <template id="engagement-table-items" is="dom-repeat"
19 items="{{engagementInfo}}" as="info"
20 sort="[[getTableSortFunction_(sortKey_, sortReverse)]]">
15 <tr> 21 <tr>
16 <td class="origin-cell">{{info.origin}}</td> 22 <td class="origin-cell">{{info.origin}}</td>
17 <td>{{info.score}}</td> 23 <td>{{info.score}}</td>
18 </tr> 24 </tr>
19 </template> 25 </template>
20 </tbody> 26 </tbody>
21 </table> 27 </table>
22 </template> 28 </template>
23 </dom-module> 29 </dom-module>
24 <script src="engagement_table.js"></script> 30 <script src="engagement_table.js"></script>
OLDNEW
« no previous file with comments | « chrome/browser/resources/engagement/engagement_table.css ('k') | chrome/browser/resources/engagement/engagement_table.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698