Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1407333007: Missed adding the isExternal property to all VM MethodMirror subclasses. (Closed)

Created:
5 years, 1 month ago by Jacob
Modified:
5 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Missed adding the isExternal property to all VM MethodMirror subclasses. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/27686cf808b120ea782132009c002dd891df2816

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M runtime/lib/mirrors_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/html_common/conversions_dartium.dart View 1 3 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jacob
https://github.com/dart-lang/sdk/issues/24834
5 years, 1 month ago (2015-11-05 01:49:06 UTC) #2
siva
lgtm
5 years, 1 month ago (2015-11-05 15:52:42 UTC) #3
Jacob
5 years, 1 month ago (2015-11-06 18:51:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
27686cf808b120ea782132009c002dd891df2816 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698