Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: runtime/lib/mirrors_impl.dart

Issue 1407333007: Missed adding the isExternal property to all VM MethodMirror subclasses. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sdk/lib/html/html_common/conversions_dartium.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // VM-specific implementation of the dart:mirrors library. 5 // VM-specific implementation of the dart:mirrors library.
6 6
7 import "dart:collection" show UnmodifiableListView, UnmodifiableMapView; 7 import "dart:collection" show UnmodifiableListView, UnmodifiableMapView;
8 import "dart:async" show Future; 8 import "dart:async" show Future;
9 9
10 var dirty = false; 10 var dirty = false;
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 this.isTopLevel, 286 this.isTopLevel,
287 this._target); 287 this._target);
288 288
289 bool get isSynthetic => true; 289 bool get isSynthetic => true;
290 bool get isRegularMethod => false; 290 bool get isRegularMethod => false;
291 bool get isOperator => false; 291 bool get isOperator => false;
292 bool get isConstructor => false; 292 bool get isConstructor => false;
293 bool get isConstConstructor => false; 293 bool get isConstConstructor => false;
294 bool get isGenerativeConstructor => false; 294 bool get isGenerativeConstructor => false;
295 bool get isFactoryConstructor => false; 295 bool get isFactoryConstructor => false;
296 bool get isExternal => false;
296 bool get isRedirectingConstructor => false; 297 bool get isRedirectingConstructor => false;
297 bool get isAbstract => false; 298 bool get isAbstract => false;
298 299
299 bool get isSetter => !isGetter; 300 bool get isSetter => !isGetter;
300 bool get isPrivate => _n(simpleName).startsWith('_'); 301 bool get isPrivate => _n(simpleName).startsWith('_');
301 302
302 Symbol get qualifiedName => _computeQualifiedName(owner, simpleName); 303 Symbol get qualifiedName => _computeQualifiedName(owner, simpleName);
303 Symbol get constructorName => const Symbol(''); 304 Symbol get constructorName => const Symbol('');
304 305
305 TypeMirror get returnType => _target.type; 306 TypeMirror get returnType => _target.type;
(...skipping 1360 matching lines...) Expand 10 before | Expand all | Expand 10 after
1666 if (typeMirror == null) { 1667 if (typeMirror == null) {
1667 typeMirror = makeLocalTypeMirror(key); 1668 typeMirror = makeLocalTypeMirror(key);
1668 _instanitationCache[key] = typeMirror; 1669 _instanitationCache[key] = typeMirror;
1669 if (typeMirror is ClassMirror && !typeMirror._isGeneric) { 1670 if (typeMirror is ClassMirror && !typeMirror._isGeneric) {
1670 _declarationCache[key] = typeMirror; 1671 _declarationCache[key] = typeMirror;
1671 } 1672 }
1672 } 1673 }
1673 return typeMirror; 1674 return typeMirror;
1674 } 1675 }
1675 } 1676 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/html/html_common/conversions_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698