runtime/lib/mirrors_impl.dart - Issue 1407333007: Missed adding the isExternal property to all VM MethodMirror subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 1407333007: Missed adding the isExternal property to all VM MethodMirror subclasses. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/mirrors_impl.dart

diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart

index 8b099c9bcf6121a398f3b9ad32f3b87f0b4dcd17..0a839fbd68df7229e85528e19b61b53ba26c558e 100644

--- a/runtime/lib/mirrors_impl.dart

+++ b/runtime/lib/mirrors_impl.dart

@@ -293,6 +293,7 @@ class _SyntheticAccessor implements MethodMirror {

bool get isConstConstructor => false;

bool get isGenerativeConstructor => false;

bool get isFactoryConstructor => false;

+ bool get isExternal => false;

bool get isRedirectingConstructor => false;

bool get isAbstract => false;

« no previous file with comments | « no previous file | sdk/lib/html/html_common/conversions_dartium.dart » ('j') | no next file with comments »