tools/bisect-builds.py - Issue 1407263008: Fix bisect-builds.py crash for non-official mac64 builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/bisect-builds.py

Issue 1407263008: Fix bisect-builds.py crash for non-official mac64 builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/bisect-builds.py

diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py

index ae7bf63b774d2526ae31b3d0bdede7246b190dcf..06ab8bdcc6f6e6a9c52f3b6a4e7c66432fc75210 100755

--- a/tools/bisect-builds.py

+++ b/tools/bisect-builds.py

@@ -192,7 +192,8 @@ class PathContext(object):

self._listing_platform_dir = 'Linux_ARM_Cross-Compile/'

elif self.platform == 'chromeos':

self._listing_platform_dir = 'Linux_ChromiumOS_Full/'

- elif self.platform == 'mac':

+ # There is no 64-bit distinction for non-official mac builds.

+ elif self.platform in ('mac', 'mac64'):

self._listing_platform_dir = 'Mac/'

self._binary_name = 'Chromium.app/Contents/MacOS/Chromium'

elif self.platform == 'win':

« no previous file with comments | « no previous file | no next file » | no next file with comments »