Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Side by Side Diff: tools/bisect-builds.py

Issue 1407263008: Fix bisect-builds.py crash for non-official mac64 builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Snapshot Build Bisect Tool 6 """Snapshot Build Bisect Tool
7 7
8 This script bisects a snapshot archive using binary search. It starts at 8 This script bisects a snapshot archive using binary search. It starts at
9 a bad revision (it will try to guess HEAD) and asks for a last known-good 9 a bad revision (it will try to guess HEAD) and asks for a last known-good
10 revision. It will then binary search across this revision range by downloading, 10 revision. It will then binary search across this revision range by downloading,
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 self.archive_name = 'chrome-linux.zip' 185 self.archive_name = 'chrome-linux.zip'
186 self._archive_extract_dir = 'chrome-linux' 186 self._archive_extract_dir = 'chrome-linux'
187 if self.platform == 'linux': 187 if self.platform == 'linux':
188 self._listing_platform_dir = 'Linux/' 188 self._listing_platform_dir = 'Linux/'
189 elif self.platform == 'linux64': 189 elif self.platform == 'linux64':
190 self._listing_platform_dir = 'Linux_x64/' 190 self._listing_platform_dir = 'Linux_x64/'
191 elif self.platform == 'linux-arm': 191 elif self.platform == 'linux-arm':
192 self._listing_platform_dir = 'Linux_ARM_Cross-Compile/' 192 self._listing_platform_dir = 'Linux_ARM_Cross-Compile/'
193 elif self.platform == 'chromeos': 193 elif self.platform == 'chromeos':
194 self._listing_platform_dir = 'Linux_ChromiumOS_Full/' 194 self._listing_platform_dir = 'Linux_ChromiumOS_Full/'
195 elif self.platform == 'mac': 195 # There is no 64-bit distinction for non-official mac builds.
196 elif self.platform in ('mac', 'mac64'):
196 self._listing_platform_dir = 'Mac/' 197 self._listing_platform_dir = 'Mac/'
197 self._binary_name = 'Chromium.app/Contents/MacOS/Chromium' 198 self._binary_name = 'Chromium.app/Contents/MacOS/Chromium'
198 elif self.platform == 'win': 199 elif self.platform == 'win':
199 self._listing_platform_dir = 'Win/' 200 self._listing_platform_dir = 'Win/'
200 201
201 def GetASANPlatformDir(self): 202 def GetASANPlatformDir(self):
202 """ASAN builds are in directories like "linux-release", or have filenames 203 """ASAN builds are in directories like "linux-release", or have filenames
203 like "asan-win32-release-277079.zip". This aligns to our platform names 204 like "asan-win32-release-277079.zip". This aligns to our platform names
204 except in the case of Windows where they use "win32" instead of "win".""" 205 except in the case of Windows where they use "win32" instead of "win"."""
205 if self.platform == 'win': 206 if self.platform == 'win':
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1257 1258
1258 print 'CHANGELOG URL:' 1259 print 'CHANGELOG URL:'
1259 if opts.official_builds: 1260 if opts.official_builds:
1260 print OFFICIAL_CHANGELOG_URL % (min_chromium_rev, max_chromium_rev) 1261 print OFFICIAL_CHANGELOG_URL % (min_chromium_rev, max_chromium_rev)
1261 else: 1262 else:
1262 PrintChangeLog(min_chromium_rev, max_chromium_rev) 1263 PrintChangeLog(min_chromium_rev, max_chromium_rev)
1263 1264
1264 1265
1265 if __name__ == '__main__': 1266 if __name__ == '__main__':
1266 sys.exit(main()) 1267 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698