chrome/browser/engagement/site_engagement_helper.cc - Issue 1407053010: Make mouse wheel events trigger WebContentsObserver::DidGetUserInteraction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper.cc

Issue 1407053010: Make mouse wheel events trigger WebContentsObserver::DidGetUserInteraction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/engagement/site_engagement_helper.cc

diff --git a/chrome/browser/engagement/site_engagement_helper.cc b/chrome/browser/engagement/site_engagement_helper.cc

index 8da594f16f4c846ec56071c62afdb6a24a550a6f..b1ead5f5db1109f6fa474bb2fa5762cabfdf0a20 100644

--- a/chrome/browser/engagement/site_engagement_helper.cc

+++ b/chrome/browser/engagement/site_engagement_helper.cc

@@ -85,6 +85,9 @@ void SiteEngagementHelper::InputTracker::DidGetUserInteraction(

case blink::WebInputEvent::GestureTapDown:

helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE);

break;

+ case blink::WebInputEvent::MouseWheel:

+ helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_WHEEL);

+ break;

default:

NOTREACHED();

}

« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_helper_unittest.cc » ('j') | content/browser/renderer_host/render_widget_host_impl.h » ('J')