Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/browser/engagement/site_engagement_helper.cc

Issue 1407053010: Make mouse wheel events trigger WebContentsObserver::DidGetUserInteraction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
calamity 2015/11/03 02:16:13 Check your bug number.
dominickn 2015/11/03 21:29:42 Done.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/engagement/site_engagement_helper.h" 5 #include "chrome/browser/engagement/site_engagement_helper.h"
6 6
7 #include "base/time/time.h" 7 #include "base/time/time.h"
8 #include "base/trace_event/trace_event.h" 8 #include "base/trace_event/trace_event.h"
9 #include "chrome/browser/engagement/site_engagement_service.h" 9 #include "chrome/browser/engagement/site_engagement_service.h"
10 #include "chrome/browser/engagement/site_engagement_service_factory.h" 10 #include "chrome/browser/engagement/site_engagement_service_factory.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 switch (type) { 78 switch (type) {
79 case blink::WebInputEvent::RawKeyDown: 79 case blink::WebInputEvent::RawKeyDown:
80 helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_KEYPRESS); 80 helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_KEYPRESS);
81 break; 81 break;
82 case blink::WebInputEvent::MouseDown: 82 case blink::WebInputEvent::MouseDown:
83 helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_MOUSE); 83 helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_MOUSE);
84 break; 84 break;
85 case blink::WebInputEvent::GestureTapDown: 85 case blink::WebInputEvent::GestureTapDown:
86 helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE); 86 helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE);
87 break; 87 break;
88 case blink::WebInputEvent::MouseWheel:
89 helper_->RecordUserInput(SiteEngagementMetrics::ENGAGEMENT_WHEEL);
90 break;
88 default: 91 default:
89 NOTREACHED(); 92 NOTREACHED();
90 } 93 }
91 Pause(); 94 Pause();
92 } 95 }
93 96
94 SiteEngagementHelper::~SiteEngagementHelper() { 97 SiteEngagementHelper::~SiteEngagementHelper() {
95 content::WebContents* contents = web_contents(); 98 content::WebContents* contents = web_contents();
96 if (contents) 99 if (contents)
97 input_tracker_.Stop(); 100 input_tracker_.Stop();
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 164
162 // static 165 // static
163 void SiteEngagementHelper::SetSecondsTrackingDelayAfterNavigation(int seconds) { 166 void SiteEngagementHelper::SetSecondsTrackingDelayAfterNavigation(int seconds) {
164 g_seconds_tracking_delay_after_navigation = seconds; 167 g_seconds_tracking_delay_after_navigation = seconds;
165 } 168 }
166 169
167 // static 170 // static
168 void SiteEngagementHelper::SetSecondsTrackingDelayAfterShow(int seconds) { 171 void SiteEngagementHelper::SetSecondsTrackingDelayAfterShow(int seconds) {
169 g_seconds_tracking_delay_after_show = seconds; 172 g_seconds_tracking_delay_after_show = seconds;
170 } 173 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698