Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: chrome/browser/engagement/site_engagement_helper_unittest.cc

Issue 1407053010: Make mouse wheel events trigger WebContentsObserver::DidGetUserInteraction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_helper_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_helper_unittest.cc b/chrome/browser/engagement/site_engagement_helper_unittest.cc
index 92789f8249d66c4c4148484c562d0fe2ff8d148c..371b84cb8e260dee6e4bb3008de8e16f48e5d2c9 100644
--- a/chrome/browser/engagement/site_engagement_helper_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_helper_unittest.cc
@@ -118,10 +118,14 @@ TEST_F(SiteEngagementHelperTest, KeyPressEngagementAccumulation) {
UserInputAccumulation(blink::WebInputEvent::RawKeyDown);
}
-TEST_F(SiteEngagementHelperTest, MouseEventEngagementAccumulation) {
+TEST_F(SiteEngagementHelperTest, MouseDownEventEngagementAccumulation) {
UserInputAccumulation(blink::WebInputEvent::MouseDown);
}
+TEST_F(SiteEngagementHelperTest, MouseWheelEventEngagementAccumulation) {
+ UserInputAccumulation(blink::WebInputEvent::MouseWheel);
+}
+
TEST_F(SiteEngagementHelperTest, GestureEngagementAccumulation) {
UserInputAccumulation(blink::WebInputEvent::GestureTapDown);
}
@@ -180,7 +184,7 @@ TEST_F(SiteEngagementHelperTest, MixedInputEngagementAccumulation) {
2);
HandleUserInputAndRestartTracking(helper.get(),
- blink::WebInputEvent::MouseDown);
+ blink::WebInputEvent::MouseWheel);
HandleUserInputAndRestartTracking(helper.get(),
blink::WebInputEvent::MouseDown);
HandleUserInputAndRestartTracking(helper.get(),
@@ -191,7 +195,9 @@ TEST_F(SiteEngagementHelperTest, MixedInputEngagementAccumulation) {
histograms.ExpectTotalCount(SiteEngagementMetrics::kEngagementTypeHistogram,
9);
histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
- SiteEngagementMetrics::ENGAGEMENT_MOUSE, 3);
+ SiteEngagementMetrics::ENGAGEMENT_MOUSE, 2);
+ histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
+ SiteEngagementMetrics::ENGAGEMENT_WHEEL, 1);
histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,
SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE,
3);

Powered by Google App Engine
This is Rietveld 408576698