Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1407003002: Don't widen selection paint rect for linebreaks. (Closed)

Created:
5 years, 2 months ago by wkorman
Modified:
5 years, 2 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't widen selection paint rect for linebreaks. BUG=543309 Committed: https://crrev.com/165f41b96b1957fbf63375d670224baecd9acaa7 Cr-Commit-Position: refs/heads/master@{#354434}

Patch Set 1 #

Patch Set 2 : Rebaseline tests with selected linebreaks to reflect fixed behavior. #

Patch Set 3 : Fix up expectations. #

Patch Set 4 : More test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 2 chunks +27 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/selection/text-selection-newline-br.html View 1 chunk +4 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/selection/text-selection-newline-br-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/paint/selection/text-selection-newline-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/spv2/paint/selection/text-selection-newline-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/paint/selection/text-selection-newline-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/spv2/paint/selection/text-selection-newline-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/paint/selection/text-selection-newline-br-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/spv2/paint/selection/text-selection-newline-br-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
wkorman
5 years, 2 months ago (2015-10-15 19:16:41 UTC) #2
chrishtr
lgtm
5 years, 2 months ago (2015-10-15 19:44:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003002/1
5 years, 2 months ago (2015-10-15 19:45:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/121233)
5 years, 2 months ago (2015-10-15 20:50:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003002/20001
5 years, 2 months ago (2015-10-15 21:32:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/127221)
5 years, 2 months ago (2015-10-15 22:26:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003002/40001
5 years, 2 months ago (2015-10-15 22:42:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407003002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407003002/60001
5 years, 2 months ago (2015-10-16 00:15:52 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-16 02:47:45 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 02:48:55 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/165f41b96b1957fbf63375d670224baecd9acaa7
Cr-Commit-Position: refs/heads/master@{#354434}

Powered by Google App Engine
This is Rietveld 408576698