third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp - Issue 1407003002: Don't widen selection paint rect for linebreaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

Issue 1407003002: Don't widen selection paint rect for linebreaks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More test expectations. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

index b438aa1d136d5506c8acfc42b002107db9c31510..590e62e14778aee0df254a588cc775baee6b6b47 100644

--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

@@ -488,7 +488,9 @@ void InlineTextBoxPainter::paintSelection(GraphicsContext* context, const Layout

FloatPoint localOrigin(boxRect.x().toFloat(), (boxRect.y() - deltaY).toFloat());

LayoutRect selectionRect = LayoutRect(font.selectionRectForText(textRun, localOrigin, selHeight, sPos, ePos));

- if (m_inlineTextBox.hasWrappedSelectionNewline())

+ if (m_inlineTextBox.hasWrappedSelectionNewline()

+ // For line breaks, just painting a selection where the line break itself is rendered is sufficient.

+ && !m_inlineTextBox.isLineBreak())

expandToIncludeNewlineForSelection(selectionRect);

context->fillRect(FloatRect(selectionRect), c);