Update DecoratedTextfield layout on icon changes.

Update DecoratedTextfield layout on icon changes.

Call Layout to update newly visible icon bounds.
Remove incorrect inset modifications for icons.

BUG=334132
TEST=rAc dialogs show icons as intended.
R=estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245378

[msw, 2014-01-16 20:26:33]

Hey Dan, please take a look; thanks!

[Evan Stade, 2014-01-16 20:40:42]

https://codereview.chromium.org/140653004/diff/30001/chrome/browser/ui/views/...
File chrome/browser/ui/views/autofill/decorated_textfield.cc (left):

https://codereview.chromium.org/140653004/diff/30001/chrome/browser/ui/views/...
chrome/browser/ui/views/autofill/decorated_textfield.cc:162: if
(icon_view_->visible() == visible)
why remove this?

[Dan Beam, 2014-01-16 21:09:33]

-dbeam@ (estade@ wrote this code)

[msw, 2014-01-16 21:10:32]

https://codereview.chromium.org/140653004/diff/30001/chrome/browser/ui/views/...
File chrome/browser/ui/views/autofill/decorated_textfield.cc (left):

https://codereview.chromium.org/140653004/diff/30001/chrome/browser/ui/views/...
chrome/browser/ui/views/autofill/decorated_textfield.cc:162: if
(icon_view_->visible() == visible)
On 2014/01/16 20:40:43, Evan Stade wrote:
> why remove this?

It seems to be necessary. I tried to dig in and understand why, but the autofill
dialog code that resets the icon on various changes is quite complex, and
|icon_view_| itself is unnecessarily reset and managed oddly in this class.
Anyway, I'm basically restoring the behavior here before my regression; see:
https://codereview.chromium.org/135863002/diff/70001/chrome/browser/ui/views/...

[Evan Stade, 2014-01-16 21:11:24]

lgtm

[commit-bot: I haz the power, 2014-01-16 21:24:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/140653004/30001

[commit-bot: I haz the power, 2014-01-16 23:48:04]

Change committed as 245378