Update DecoratedTextfield layout on icon changes.

chrome/browser/ui/views/autofill/decorated_textfield.cc

Index: chrome/browser/ui/views/autofill/decorated_textfield.cc
diff --git a/chrome/browser/ui/views/autofill/decorated_textfield.cc b/chrome/browser/ui/views/autofill/decorated_textfield.cc
index 94e8202c7655ffbb8edc403a80d7b34dd58294a8..74361ce15bb5080e106dc90a295c976690ca02d5 100644
--- a/chrome/browser/ui/views/autofill/decorated_textfield.cc
+++ b/chrome/browser/ui/views/autofill/decorated_textfield.cc
@@ -144,27 +144,13 @@ void DecoratedTextfield::UpdateBorder() {
     border->SetColor(kWarningColor);
   else if (!editable_)
     border->SetColor(SK_ColorTRANSPARENT);
-
-  const gfx::Insets insets = GetInsets();
-  int left = icon_view_ ?
-      icon_view_->GetPreferredSize().width() + 2 * kTextfieldIconPadding : 0;
-  int right = 0;
-  if (base::i18n::IsRTL())
-    std::swap(left, right);
-  border->SetInsets(insets.top(), insets.left() + left, insets.bottom(),
-                    insets.right() + right);
   set_border(border);
 }
 
 void DecoratedTextfield::IconChanged() {
   // Don't show the icon if nothing else is showing.
-  const bool visible = editable_ || !text().empty();
-  if (icon_view_->visible() == visible)

[Evan Stade, 2014/01/16 20:40:43]

why remove this?

[msw, 2014/01/16 21:10:33]

It seems to be necessary. I tried to dig in and understand why, but the autofill
dialog code that resets the icon on various changes is quite complex, and
|icon_view_| itself is unnecessarily reset and managed oddly in this class.
Anyway, I'm basically restoring the behavior here before my regression; see:
https://codereview.chromium.org/135863002/diff/70001/chrome/browser/ui/views/...

-    return;
-
-  icon_view_->SetVisible(visible);
-  UpdateBorder();
-  SchedulePaint();
+  icon_view_->SetVisible(editable_ || !text().empty());
+  Layout();
 }
 
 } // namespace autofill