Update DecoratedTextfield layout on icon changes.

chrome/browser/ui/views/autofill/decorated_textfield.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/decorated_textfield.h"
 
 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
 #include "chrome/browser/ui/views/autofill/tooltip_icon.h"
 #include "ui/gfx/canvas.h"
 #include "ui/views/background.h"
@@ skipping 126 matching lines @@
   set_background(
       views::Background::CreateSolidBackground(GetBackgroundColor()));
 }
 
 void DecoratedTextfield::UpdateBorder() {
   views::FocusableBorder* border = new views::FocusableBorder();
   if (invalid_)
     border->SetColor(kWarningColor);
   else if (!editable_)
     border->SetColor(SK_ColorTRANSPARENT);
-
-  const gfx::Insets insets = GetInsets();
-  int left = icon_view_ ?
-      icon_view_->GetPreferredSize().width() + 2 * kTextfieldIconPadding : 0;
-  int right = 0;
-  if (base::i18n::IsRTL())
-    std::swap(left, right);
-  border->SetInsets(insets.top(), insets.left() + left, insets.bottom(),
-                    insets.right() + right);
   set_border(border);
 }
 
 void DecoratedTextfield::IconChanged() {
   // Don't show the icon if nothing else is showing.
-  const bool visible = editable_ || !text().empty();
-  if (icon_view_->visible() == visible)

[Evan Stade, 2014/01/16 20:40:43]

why remove this?

[msw, 2014/01/16 21:10:33]

It seems to be necessary. I tried to dig in and understand why, but the autofill
dialog code that resets the icon on various changes is quite complex, and
|icon_view_| itself is unnecessarily reset and managed oddly in this class.
Anyway, I'm basically restoring the behavior here before my regression; see:
https://codereview.chromium.org/135863002/diff/70001/chrome/browser/ui/views/...

-    return;
-
-  icon_view_->SetVisible(visible);
-  UpdateBorder();
-  SchedulePaint();
+  icon_view_->SetVisible(editable_ || !text().empty());
+  Layout();
 }
 
 } // namespace autofill