build/config/android/config.gni - Issue 1406173004: GN: Add an assert for proper output directory nesting on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/config.gni

Issue 1406173004: GN: Add an assert for proper output directory nesting on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/android/config.gni

diff --git a/build/config/android/config.gni b/build/config/android/config.gni

index 19ed535f36a5b789c5a2155e27d7f906d682c046..9b141f9020e4a017c3318f596b61b1f20bf2bc23 100644

--- a/build/config/android/config.gni

+++ b/build/config/android/config.gni

@@ -5,6 +5,9 @@

# This file contains common system config stuff for the Android build.

if (is_android) {

+ assert(rebase_path("//", root_build_dir) == "../../",

+ "Android output directory must be nested 2 levels within src/ (" +

+ "e.g.: out-gn/Debug). http://crbug.com/412935")

has_chrome_android_internal =

exec_script("//build/dir_exists.py",

[ rebase_path("//clank", root_build_dir) ],

« no previous file with comments | « no previous file | no next file » | no next file with comments »