Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1406153004: components/mus/public/interfaces View => Window (Closed)

Created:
5 years, 2 months ago by Fady Samuel
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, tfarina, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

components/mus/public/interfaces View => Window This CL updates the namespace of the mojoms to mus.mojom. BUG=542848 TBR=ben@chromium.org Committed: https://crrev.com/3c32ae57723269239c36582c2dbd1ee1ac6f36cd Cr-Commit-Position: refs/heads/master@{#354643}

Patch Set 1 #

Patch Set 2 : window_tree.mojom uses mus.mojom namesapce #

Patch Set 3 : Rebase #

Patch Set 4 : Yet another rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1999 lines, -1885 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/document_resource_waiter.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/document_resource_waiter.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/global_state.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M components/html_viewer/global_state.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/html_document.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M components/html_viewer/html_widget.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_graphics_context_3d_command_buffer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/example/wm/window_manager_application.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/example/wm/window_manager_apptest.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M components/mus/example/wm/window_manager_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/mus/example/wm/window_manager_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/command_buffer_driver.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M components/mus/gles2/command_buffer_type_conversions.h View 1 chunk +22 lines, -20 lines 0 comments Download
M components/mus/gles2/command_buffer_type_conversions.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M components/mus/gles2/gpu_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/gles2/gpu_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/mus_app.h View 1 3 chunks +17 lines, -17 lines 0 comments Download
M components/mus/mus_app.cc View 1 6 chunks +11 lines, -11 lines 0 comments Download
M components/mus/public/cpp/lib/output_surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/window.cc View 1 2 3 11 chunks +22 lines, -21 lines 0 comments Download
M components/mus/public/cpp/lib/window_private.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/public/cpp/lib/window_surface.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 2 3 7 chunks +20 lines, -19 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 2 3 15 chunks +35 lines, -35 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_host_factory.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M components/mus/public/cpp/output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/window_unittest.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M components/mus/public/cpp/window.h View 1 2 3 6 chunks +12 lines, -10 lines 0 comments Download
M components/mus/public/cpp/window_observer.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/public/cpp/window_surface.h View 3 chunks +9 lines, -9 lines 0 comments Download
M components/mus/public/cpp/window_surface_client.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/window_tree_connection.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/window_tree_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/window_tree_host_factory.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/interfaces/command_buffer.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/interfaces/compositor_frame.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/interfaces/gpu.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/gpu_capabilities.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/mus_constants.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/interfaces/quads.mojom View 9 chunks +24 lines, -24 lines 0 comments Download
M components/mus/public/interfaces/surface_id.mojom View 1 chunk +1 line, -1 line 0 comments Download
D components/mus/public/interfaces/view_tree.mojom View 1 2 3 1 chunk +0 lines, -258 lines 0 comments Download
D components/mus/public/interfaces/view_tree_host.mojom View 1 chunk +0 lines, -41 lines 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A components/mus/public/interfaces/window_tree.mojom View 1 2 3 1 chunk +259 lines, -0 lines 0 comments Download
A + components/mus/public/interfaces/window_tree_host.mojom View 1 3 chunks +10 lines, -10 lines 0 comments Download
M components/mus/ws/access_policy.h View 1 2 3 2 chunks +12 lines, -12 lines 0 comments Download
M components/mus/ws/client_connection.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
M components/mus/ws/client_connection.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/connection_manager.h View 1 2 3 7 chunks +10 lines, -10 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 1 2 3 10 chunks +21 lines, -19 lines 0 comments Download
M components/mus/ws/connection_manager_delegate.h View 1 3 chunks +4 lines, -5 lines 0 comments Download
M components/mus/ws/default_access_policy.h View 1 2 3 1 chunk +11 lines, -11 lines 0 comments Download
M components/mus/ws/default_access_policy.cc View 1 2 3 4 chunks +13 lines, -12 lines 0 comments Download
M components/mus/ws/display_manager.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M components/mus/ws/display_manager.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/display_manager_delegate.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/ids.h View 2 chunks +7 lines, -7 lines 0 comments Download
M components/mus/ws/server_view.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M components/mus/ws/server_view.cc View 1 2 3 5 chunks +10 lines, -10 lines 0 comments Download
M components/mus/ws/server_view_observer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/server_view_surface.h View 4 chunks +9 lines, -9 lines 0 comments Download
M components/mus/ws/server_view_surface.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/mus/ws/test_change_tracker.h View 1 6 chunks +26 lines, -26 lines 0 comments Download
M components/mus/ws/test_change_tracker.cc View 1 12 chunks +62 lines, -62 lines 0 comments Download
M components/mus/ws/view_manager_client_apptest.cc View 1 2 3 5 chunks +9 lines, -7 lines 0 comments Download
M components/mus/ws/view_tree_apptest.cc View 1 2 3 73 chunks +415 lines, -405 lines 0 comments Download
M components/mus/ws/view_tree_host_connection.h View 1 4 chunks +9 lines, -8 lines 0 comments Download
M components/mus/ws/view_tree_host_connection.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/mus/ws/view_tree_host_delegate.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/mus/ws/view_tree_host_impl.h View 1 6 chunks +9 lines, -9 lines 0 comments Download
M components/mus/ws/view_tree_host_impl.cc View 1 6 chunks +9 lines, -10 lines 0 comments Download
M components/mus/ws/view_tree_impl.h View 1 2 3 10 chunks +64 lines, -63 lines 0 comments Download
M components/mus/ws/view_tree_impl.cc View 1 2 3 25 chunks +132 lines, -126 lines 0 comments Download
M components/mus/ws/view_tree_unittest.cc View 1 2 3 17 chunks +47 lines, -47 lines 0 comments Download
M components/mus/ws/window_manager_access_policy.h View 1 2 3 1 chunk +11 lines, -11 lines 0 comments Download
M components/mus/ws/window_manager_access_policy.cc View 1 2 3 2 chunks +11 lines, -10 lines 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 1 13 chunks +30 lines, -28 lines 0 comments Download
M components/web_view/frame.h View 1 7 chunks +7 lines, -7 lines 0 comments Download
M components/web_view/frame.cc View 1 8 chunks +32 lines, -28 lines 0 comments Download
M components/web_view/frame_apptest.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M components/web_view/frame_connection.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/web_view/frame_connection.cc View 1 4 chunks +10 lines, -10 lines 0 comments Download
M components/web_view/frame_tree.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_view/frame_tree.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/frame_tree_delegate.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/web_view/public/cpp/web_view.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M components/web_view/public/interfaces/web_view.mojom View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.h View 3 chunks +2 lines, -6 lines 0 comments Download
M components/web_view/web_view_impl.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/web_view/web_view_impl.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.h View 6 chunks +6 lines, -7 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M mandoline/ui/desktop_ui/public/interfaces/omnibox.mojom View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_application.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/custom_surface_converter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.h View 1 chunk +77 lines, -58 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 16 chunks +66 lines, -24 lines 0 comments Download
M mojo/converters/surfaces/surfaces_utils.h View 1 chunk +5 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/surfaces_utils.cc View 2 chunks +7 lines, -1 line 0 comments Download
M mojo/converters/surfaces/tests/surface_unittest.cc View 11 chunks +152 lines, -115 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 3 chunks +7 lines, -6 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 7 chunks +18 lines, -17 lines 0 comments Download
M ui/views/mus/surface_binding.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Fady Samuel
5 years, 2 months ago (2015-10-16 22:28:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406153004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406153004/20001
5 years, 2 months ago (2015-10-16 22:30:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/82592) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-16 22:35:31 UTC) #6
Ben Goodger (Google)
lgtm
5 years, 2 months ago (2015-10-16 23:03:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406153004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406153004/40001
5 years, 2 months ago (2015-10-16 23:04:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/111310) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-16 23:07:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406153004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406153004/60001
5 years, 2 months ago (2015-10-16 23:17:12 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-16 23:49:20 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 23:50:11 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3c32ae57723269239c36582c2dbd1ee1ac6f36cd
Cr-Commit-Position: refs/heads/master@{#354643}

Powered by Google App Engine
This is Rietveld 408576698