Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1406043002: Registry memory leak fixes. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Registry memory leak fixes. Fixes #24549. A few notes: * does away with registry in favor of context-associated configurations * pulls in linter rev that does the context association * bumps analyzer version before publishing (needed to update analyzer_cli) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/91e5facc0f1738bae94a9f4b3f7958d47de7ac92

Patch Set 1 #

Patch Set 2 : removed overrides. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/services/lint.dart View 3 chunks +20 lines, -8 lines 1 comment Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 2 months ago (2015-10-15 21:19:33 UTC) #2
scheglov
lgtm
5 years, 2 months ago (2015-10-15 21:20:53 UTC) #3
pquitslund
Committed patchset #2 (id:20001) manually as 91e5facc0f1738bae94a9f4b3f7958d47de7ac92 (presubmit successful).
5 years, 2 months ago (2015-10-15 21:24:25 UTC) #4
Brian Wilkerson
5 years, 2 months ago (2015-10-15 21:31:05 UTC) #5
Message was sent while issue was closed.
LGTM

https://codereview.chromium.org/1406043002/diff/20001/pkg/analyzer/lib/src/se...
File pkg/analyzer/lib/src/services/lint.dart (right):

https://codereview.chromium.org/1406043002/diff/20001/pkg/analyzer/lib/src/se...
pkg/analyzer/lib/src/services/lint.dart:49: static const List<Linter> _noLints =
const <Linter>[];
The rest of the code base generally defines constants like this in the class of
the element type (Linter in this case). Might be good to be consistent.

Powered by Google App Engine
This is Rietveld 408576698