pkg/analyzer/lib/src/task/dart.dart - Issue 1406043002: Registry memory leak fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 1406043002: Registry memory leak fixes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: removed overrides. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/task/dart.dart

diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart

index dc484ed9d2b252c594052dc8b699213652dbe5a3..b87f7763338f8bf316b1c20dcced7f3d227295d5 100644

--- a/pkg/analyzer/lib/src/task/dart.dart

+++ b/pkg/analyzer/lib/src/task/dart.dart

@@ -2613,7 +2613,7 @@ class GenerateLintsTask extends SourceBasedAnalysisTask {

// Generate lints.

- List<Linter> linters = lintRegistry[context] ?? [];

+ List<Linter> linters = getLints(context);

linters.forEach((l) => l.reporter = errorReporter);

Iterable<AstVisitor> visitors = linters.map((l) => l.getVisitor()).toList();

unit.accept(new DelegatingAstVisitor(visitors.where((v) => v != null)));