pkg/analysis_server/test/analysis/notification_errors_test.dart - Issue 1406043002: Registry memory leak fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/analysis/notification_errors_test.dart

Issue 1406043002: Registry memory leak fixes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: removed overrides. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/test/analysis/notification_errors_test.dart

diff --git a/pkg/analysis_server/test/analysis/notification_errors_test.dart b/pkg/analysis_server/test/analysis/notification_errors_test.dart

index 7cc7099252a450d5c35f5eefdaf497547cc1eabf..46de68d6383ff0d164bac30744a24cbebb28eaeb 100644

--- a/pkg/analysis_server/test/analysis/notification_errors_test.dart

+++ b/pkg/analysis_server/test/analysis/notification_errors_test.dart

@@ -87,10 +87,8 @@ linter:

handleSuccessfulRequest(request);

return waitForTasksFinished().then((_) {

- // Confirm lint is registered.

- expect(lintRegistry, isNotEmpty);

AnalysisContext testContext = server.getContainingContext(testFile);

- List<Linter> lints = lintRegistry[testContext];

+ List<Linter> lints = getLints(testContext);

// Registry should only contain single lint rule.

expect(lints, hasLength(1));

LintRule lint = lints.first as LintRule;