Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1406013009: Update the documentation for LoadCommittedDetails::previous_url. (Closed)

Created:
5 years, 1 month ago by Charlie Reis
Modified:
5 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, robwu, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the documentation for LoadCommittedDetails::previous_url. BUG=552317 TEST=No behavior change. Committed: https://crrev.com/c88f2abbae3284b81abd7e26b1e0274846a4c1c1 Cr-Commit-Position: refs/heads/master@{#358716}

Patch Set 1 #

Patch Set 2 : Change to a documentation update #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/public/browser/navigation_details.h View 1 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 11 (3 generated)
Charlie Reis
Avi, can you take a look? Rob needs this for an upcoming CL. (Feel free ...
5 years, 1 month ago (2015-11-06 22:55:42 UTC) #2
Charlie Reis
Actually, it looks like this might be the wrong thing to do. The API was ...
5 years, 1 month ago (2015-11-07 00:03:54 UTC) #3
Charlie Reis
Changed this to be a documentation update.
5 years, 1 month ago (2015-11-09 22:40:08 UTC) #5
Avi (use Gerrit)
LGTM with a random question you can ignore. https://codereview.chromium.org/1406013009/diff/20001/content/public/browser/navigation_details.h File content/public/browser/navigation_details.h (right): https://codereview.chromium.org/1406013009/diff/20001/content/public/browser/navigation_details.h#newcode39 content/public/browser/navigation_details.h:39: // ...
5 years, 1 month ago (2015-11-09 22:42:24 UTC) #6
Charlie Reis
https://codereview.chromium.org/1406013009/diff/20001/content/public/browser/navigation_details.h File content/public/browser/navigation_details.h (right): https://codereview.chromium.org/1406013009/diff/20001/content/public/browser/navigation_details.h#newcode39 content/public/browser/navigation_details.h:39: // there was no last committed entry. On 2015/11/09 ...
5 years, 1 month ago (2015-11-09 22:55:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406013009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406013009/20001
5 years, 1 month ago (2015-11-09 22:56:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-10 00:39:49 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 00:40:53 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c88f2abbae3284b81abd7e26b1e0274846a4c1c1
Cr-Commit-Position: refs/heads/master@{#358716}

Powered by Google App Engine
This is Rietveld 408576698