Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: content/public/browser/navigation_details.h

Issue 1406013009: Update the documentation for LoadCommittedDetails::previous_url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change to a documentation update Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_
7 7
8 #include <string> 8 #include <string>
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/browser/navigation_type.h" 10 #include "content/public/browser/navigation_type.h"
(...skipping 17 matching lines...) Expand all
28 28
29 // The type of navigation that just occurred. Note that not all types of 29 // The type of navigation that just occurred. Note that not all types of
30 // navigations in the enum are valid here, since some of them don't actually 30 // navigations in the enum are valid here, since some of them don't actually
31 // cause a "commit" and won't generate this notification. 31 // cause a "commit" and won't generate this notification.
32 content::NavigationType type; 32 content::NavigationType type;
33 33
34 // The index of the previously committed navigation entry. This will be -1 34 // The index of the previously committed navigation entry. This will be -1
35 // if there are no previous entries. 35 // if there are no previous entries.
36 int previous_entry_index; 36 int previous_entry_index;
37 37
38 // The previous URL that the user was on. This may be empty if none. 38 // The previous main frame URL that the user was on. This may be empty if
39 // there was no last committed entry.
Avi (use Gerrit) 2015/11/09 22:42:24 How does this interact with your change to make su
Charlie Reis 2015/11/09 22:55:28 Yep, it won't be possible after https://codereview
39 GURL previous_url; 40 GURL previous_url;
40 41
41 // True if the committed entry has replaced the exisiting one. 42 // True if the committed entry has replaced the exisiting one.
42 // A non-user initiated redirect causes such replacement. 43 // A non-user initiated redirect causes such replacement.
43 bool did_replace_entry; 44 bool did_replace_entry;
44 45
45 // True if the navigation was in-page. This means that the active entry's 46 // True if the navigation was in-page. This means that the active entry's
46 // URL and the |previous_url| are the same except for reference fragments. 47 // URL and the |previous_url| are the same except for reference fragments.
47 bool is_in_page; 48 bool is_in_page;
48 49
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 // count items were removed from the back of the list. 84 // count items were removed from the back of the list.
84 bool from_front; 85 bool from_front;
85 86
86 // Number of items removed. 87 // Number of items removed.
87 int count; 88 int count;
88 }; 89 };
89 90
90 } // namespace content 91 } // namespace content
91 92
92 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_ 93 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_DETAILS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698