Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-high.html

Issue 1405393002: Crashes when percent calculation of row's height goes very high. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments addressed Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-high.html
diff --git a/third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-high.html b/third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-high.html
new file mode 100644
index 0000000000000000000000000000000000000000..cff3aab761037a685827dfca2981fa0615cf9f91
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-high.html
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
mstensho (USE GERRIT) 2015/11/02 10:46:42 Expectation file missing. Right now this looks lik
a.suchit2 2016/01/13 13:37:59 Done.
+<style>
+ td { font: 15px/1 Ahem }
+ #row-height { height : 48515% }
+</style>
+<body>
+ <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=408066">408066</a>. Page is crashing on assression when table row span cell's percent height is too height.</h3>
mstensho (USE GERRIT) 2015/11/02 10:46:42 Please wrap this line and proof-read the text.
a.suchit2 2016/01/13 13:37:59 Done.
+ <h4>For this test to PASS, it should not crash.</h4>
+ <table>
+ <tr id="row-height">
+ <td height="876543210" rowspan="2">This row span cell height is too height.</td>
mstensho (USE GERRIT) 2015/11/02 10:46:42 "too large"
a.suchit2 2016/01/13 13:37:59 It was not reproducing without this too large valu
mstensho (USE GERRIT) 2016/01/18 14:37:03 Yes, but I'm talking about the text. It should be
a.suchit2 2016/01/19 13:02:16 Done.
+ </tr>
+ <tr id="row-height">
mstensho (USE GERRIT) 2015/11/02 10:46:42 Two elements with the same ID. Maybe use .class in
a.suchit2 2016/01/13 13:37:59 Done.
+ <td></td>
+ </tr>
+ </table>
+</body>

Powered by Google App Engine
This is Rietveld 408576698