third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-high.html - Issue 1405393002: Crashes when percent calculation of row's height goes very high.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-high.html

Issue 1405393002: Crashes when percent calculation of row's height goes very high. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	mstensho (USE GERRIT) 2015/11/02 10:46:42 Expectation file missing. Right now this looks lik Expectation file missing. Right now this looks like a crash test, so you should add <script> if (window.testRunner) testRunner.dumpAsText(); </script> ... and store and upload the -expected.txt file. a.suchit2 2016/01/13 13:37:59 Done. Show quoted text On 2015/11/02 10:46:42, mstensho wrote: > Expectation file missing. Right now this looks like a crash test, so you should > add > > <script> > if (window.testRunner) > testRunner.dumpAsText(); > </script> > > ... and store and upload the -expected.txt file. Done.
	2 <style>

	3 td { font: 15px/1 Ahem }

	4 #row-height { height : 48515% }

	5 </style>

	6 <body>

	7 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issu es/detail?id=408066">408066</a>. Page is crashing on assression when table row s pan cell's percent height is too height.</h3>
	mstensho (USE GERRIT) 2015/11/02 10:46:42 Please wrap this line and proof-read the text. Please wrap this line and proof-read the text. a.suchit2 2016/01/13 13:37:59 Done. Show quoted text On 2015/11/02 10:46:42, mstensho wrote: > Please wrap this line and proof-read the text. Done.
	8 <h4>For this test to PASS, it should not crash.</h4>

	9 <table>

	10 <tr id="row-height">

	11 <td height="876543210" rowspan="2">This row span cell height is too height.</td>
	mstensho (USE GERRIT) 2015/11/02 10:46:42 "too large" "too large" a.suchit2 2016/01/13 13:37:59 It was not reproducing without this too large valu Show quoted text On 2015/11/02 10:46:42, mstensho wrote: > "too large" It was not reproducing without this too large value. Sp I kept it large value. mstensho (USE GERRIT) 2016/01/18 14:37:03 Yes, but I'm talking about the text. It should be Show quoted text On 2016/01/13 13:37:59, a.suchit2 wrote: > On 2015/11/02 10:46:42, mstensho wrote: > > "too large" > > It was not reproducing without this too large value. Sp I kept it large value. Yes, but I'm talking about the text. It should be "too large", not "too height". a.suchit2 2016/01/19 13:02:16 Done. Show quoted text On 2016/01/18 14:37:03, mstensho wrote: > On 2016/01/13 13:37:59, a.suchit2 wrote: > > On 2015/11/02 10:46:42, mstensho wrote: > > > "too large" > > > > It was not reproducing without this too large value. Sp I kept it large value. > > Yes, but I'm talking about the text. It should be "too large", not "too height". Done.
	12 </tr>

	13 <tr id="row-height">
	mstensho (USE GERRIT) 2015/11/02 10:46:42 Two elements with the same ID. Maybe use .class in Two elements with the same ID. Maybe use .class instead of #id? a.suchit2 2016/01/13 13:37:59 Done. Show quoted text On 2015/11/02 10:46:42, mstensho wrote: > Two elements with the same ID. Maybe use .class instead of #id? Done.
	14 <td></td>

	15 </tr>

	16 </table>

	17 </body>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTableSection.h » ('j') | third_party/WebKit/Source/core/layout/LayoutTableSection.h » ('J')