third_party/WebKit/Source/core/layout/LayoutTableSection.h - Issue 1405393002: Crashes when percent calculation of row's height goes very high.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.h

Issue 1405393002: Crashes when percent calculation of row's height goes very high. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-high.html ('K') | « third_party/WebKit/LayoutTests/fast/table/table-rowspan-table-height-and-row-precent-height-too-high.html ('k') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTableSection.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.h b/third_party/WebKit/Source/core/layout/LayoutTableSection.h

index f6d5a9345db2d84b2af8ea08e63c5f86f905db51..f747b4f32e647f0ff9ef6d6de041cb9faaa4625d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.h

+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.h

@@ -311,7 +311,8 @@ private:

void updateRowsHeightHavingOnlySpanningCells(LayoutTableCell*, struct SpanningRowsHeight&, unsigned&, Vector<int>&);

void populateSpanningRowsHeightFromCell(LayoutTableCell*, struct SpanningRowsHeight&);

- void distributeExtraRowSpanHeightToPercentRows(LayoutTableCell*, int, int&, Vector<int>&);

+ void distributeExtraRowSpanHeightToPercentRows(LayoutTableCell*, float,

+ int&, Vector<int>&);

mstensho (USE GERRIT) 2015/11/02 10:46:42 Please put it back on one line.

a.suchit2 2016/01/12 06:46:35 Done.

void distributeWholeExtraRowSpanHeightToPercentRows(LayoutTableCell*, float, int&, Vector<int>&);

void distributeExtraRowSpanHeightToAutoRows(LayoutTableCell*, int, int&, Vector<int>&);

void distributeExtraRowSpanHeightToRemainingRows(LayoutTableCell*, int, int&, Vector<int>&);