Add a new distillability model for the new set of page features

Add a new distillability model for the new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (added in http://crrev.com/1419033004/).

The old features are extracted by JavaScript code in an isolated world,
so it's slow and consumes more memory than we could afford. Even if we
extract the old features in native code, it will still be too slow, so
we switch to this new set of features.

BUG=509869, 471439
Committed: https://crrev.com/8587df371e24c3003b743a3bb0fc87ad77152804
Cr-Commit-Position: refs/heads/master@{#359512}

[wychen, 2015-11-04 08:58:36]

Patchset #1 (id:1) has been deleted

[wychen, 2015-11-04 09:05:19]

Description was changed from

==========
Add a new distillability model for new set of page features

BUG=509869
==========

to

==========
Add a new distillability model for new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures.


BUG=509869
==========

[wychen, 2015-11-04 09:05:59]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2015-11-04 09:05:59]

PTAL

[mdjones, 2015-11-04 19:18:00]

The CQ bit was checked by mdjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 19:18:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405233009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405233009/20001

[commit-bot: I haz the power, 2015-11-04 19:38:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 19:39:00]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wychen, 2015-11-05 00:34:10]

Patchset #2 (id:40001) has been deleted

[wychen, 2015-11-05 00:39:42]

Description was changed from

==========
Add a new distillability model for new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures.


BUG=509869
==========

to

==========
Add a new distillability model for new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures.

BUG=509869
==========

[mdjones, 2015-11-05 00:53:57]

lgtm

https://codereview.chromium.org/1405233009/diff/60001/components/dom_distille...
File components/dom_distiller/core/distillable_page_detector.h (right):

https://codereview.chromium.org/1405233009/diff/60001/components/dom_distille...
components/dom_distiller/core/distillable_page_detector.h:22: static const
DistillablePageDetector* GetNewDefault();
Nit: For now, use GetNewModel and later change it to GetDefault when the old
model is removed.

[wychen, 2015-11-05 02:00:39]

https://codereview.chromium.org/1405233009/diff/60001/components/dom_distille...
File components/dom_distiller/core/distillable_page_detector.h (right):

https://codereview.chromium.org/1405233009/diff/60001/components/dom_distille...
components/dom_distiller/core/distillable_page_detector.h:22: static const
DistillablePageDetector* GetNewDefault();
On 2015/11/05 00:53:57, mdjones wrote:
> Nit: For now, use GetNewModel and later change it to GetDefault when the old
> model is removed.

Done.

[wychen, 2015-11-12 00:38:31]

Description was changed from

==========
Add a new distillability model for new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures.

BUG=509869
==========

to

==========
Add a new distillability model for new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures, which are faster to compute than
the old features.

BUG=509869
==========

[wychen, 2015-11-12 02:03:09]

Description was changed from

==========
Add a new distillability model for new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures, which are faster to compute than
the old features.

BUG=509869
==========

to

==========
Add a new distillability model for new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (http://crrev.com/1419033004/),
which are faster to compute than the old features.

BUG=509869
==========

[wychen, 2015-11-12 02:08:27]

Description was changed from

==========
Add a new distillability model for new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (http://crrev.com/1419033004/),
which are faster to compute than the old features.

BUG=509869
==========

to

==========
Add a new distillability model for the new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (added in http://crrev.com/1419033004/).

The old features are extracted by JavaScript code in an isolated world,
so it's slow and consume more memory than needed. However, even if the
old features are extracted by native code, it is still too slow, so we
switch to this new set of features.

BUG=509869
==========

[wychen, 2015-11-12 02:26:06]

Description was changed from

==========
Add a new distillability model for the new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (added in http://crrev.com/1419033004/).

The old features are extracted by JavaScript code in an isolated world,
so it's slow and consume more memory than needed. However, even if the
old features are extracted by native code, it is still too slow, so we
switch to this new set of features.

BUG=509869
==========

to

==========
Add a new distillability model for the new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (added in http://crrev.com/1419033004/).

The old features are extracted by JavaScript code in an isolated world,
so it's slow and consumes more memory than needed. However, even if we
extract the old features in native code, it will still be too slow, so
we switch to this new set of features.

BUG=509869
==========

[wychen, 2015-11-12 03:39:59]

Description was changed from

==========
Add a new distillability model for the new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (added in http://crrev.com/1419033004/).

The old features are extracted by JavaScript code in an isolated world,
so it's slow and consumes more memory than needed. However, even if we
extract the old features in native code, it will still be too slow, so
we switch to this new set of features.

BUG=509869
==========

to

==========
Add a new distillability model for the new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (added in http://crrev.com/1419033004/).

The old features are extracted by JavaScript code in an isolated world,
so it's slow and consumes more memory than we could afford. Even if we
extract the old features in native code, it will still be too slow, so
we switch to this new set of features.

BUG=509869
==========

[wychen, 2015-11-13 02:33:05]

Description was changed from

==========
Add a new distillability model for the new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (added in http://crrev.com/1419033004/).

The old features are extracted by JavaScript code in an isolated world,
so it's slow and consumes more memory than we could afford. Even if we
extract the old features in native code, it will still be too slow, so
we switch to this new set of features.

BUG=509869
==========

to

==========
Add a new distillability model for the new set of page features

This model is for the new set of features derived from
blink::WebDistillabilityFeatures (added in http://crrev.com/1419033004/).

The old features are extracted by JavaScript code in an isolated world,
so it's slow and consumes more memory than we could afford. Even if we
extract the old features in native code, it will still be too slow, so
we switch to this new set of features.

BUG=509869, 471439
==========

[wychen, 2015-11-13 07:13:15]

The CQ bit was checked by wychen@chromium.org

[wychen, 2015-11-13 07:13:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org
Link to the patchset: https://codereview.chromium.org/1405233009/#ps80001
(title: "address mdjones' comments")

[commit-bot: I haz the power, 2015-11-13 07:13:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1405233009/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1405233009/80001

[commit-bot: I haz the power, 2015-11-13 08:03:36]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-11-13 08:04:37]

Patchset 3 (id:??) landed as
https://crrev.com/8587df371e24c3003b743a3bb0fc87ad77152804
Cr-Commit-Position: refs/heads/master@{#359512}