Add a new set of page features for distillability testing

Add a new set of page features for distillability testing

BUG=509869
TEST=components_unittests --gtest_filter="DomDistillerPageFeaturesTest*"

Committed: https://crrev.com/0bbb0a0a98c99f781c4c7e01d24db71cf06def68
Cr-Commit-Position: refs/heads/master@{#359177}

[wychen, 2015-11-04 06:25:43]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2015-11-04 06:25:43]

PTAL

[wychen, 2015-11-04 10:29:06]

Patchset #1 (id:1) has been deleted

[mdjones, 2015-11-04 19:17:52]

The CQ bit was checked by mdjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 19:18:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409133007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409133007/20001

[commit-bot: I haz the power, 2015-11-04 19:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 19:39:01]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wychen, 2015-11-04 19:43:48]

wychen@chromium.org changed reviewers:
+ dglazkov@chromium.org, esprehn@chromium.org

[wychen, 2015-11-04 19:43:48]

+esprehn@, dglazkov@ for DEPS review.

[blundell, 2015-11-04 19:49:17]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2015-11-04 19:49:18]

https://codereview.chromium.org/1409133007/diff/20001/components/dom_distille...
File components/dom_distiller/DEPS (right):

https://codereview.chromium.org/1409133007/diff/20001/components/dom_distille...
components/dom_distiller/DEPS:11: "+third_party/WebKit/public/platform",
This dependency is not allowed in code shared on iOS. (For more info, see the
design doc referenced at line 23 of this file). It looks like you're just using
the struct for convenience; could you just test the individual functions or pass
the exploded parameters of the struct instead?

[wychen, 2015-11-05 00:29:32]

Patchset #2 (id:40001) has been deleted

[wychen, 2015-11-05 00:43:36]

On 2015/11/04 19:49:18, blundell wrote:
>
https://codereview.chromium.org/1409133007/diff/20001/components/dom_distille...
> File components/dom_distiller/DEPS (right):
> 
>
https://codereview.chromium.org/1409133007/diff/20001/components/dom_distille...
> components/dom_distiller/DEPS:11: "+third_party/WebKit/public/platform",
> This dependency is not allowed in code shared on iOS. (For more info, see the
> design doc referenced at line 23 of this file). It looks like you're just
using
> the struct for convenience; could you just test the individual functions or
pass
> the exploded parameters of the struct instead?

This is fixed in patch set 2. PTAL.

[mdjones, 2015-11-05 00:51:22]

lgtm

[wychen, 2015-11-05 01:19:03]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 01:19:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409133007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409133007/60001

[commit-bot: I haz the power, 2015-11-05 03:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 03:44:48]

Dry run: This issue passed the CQ dry run.

[blundell, 2015-11-05 09:35:07]

Thanks!

[wychen, 2015-11-11 18:49:44]

The CQ bit was checked by wychen@chromium.org

[wychen, 2015-11-11 18:50:29]

The CQ bit was unchecked by wychen@chromium.org

[commit-bot: I haz the power, 2015-11-11 18:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 18:50:31]

This CL has an open dependency (Issue 1419033004 Patch 330001). Please resolve
the dependency and try again.

[wychen, 2015-11-11 21:32:53]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2015-11-11 21:36:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409133007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409133007/60001

[commit-bot: I haz the power, 2015-11-11 22:51:06]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-11-12 20:01:23]

Patchset 2 (id:??) landed as
https://crrev.com/0bbb0a0a98c99f781c4c7e01d24db71cf06def68
Cr-Commit-Position: refs/heads/master@{#359177}