Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 14052009: Improve optimization of operations on indexables by using more inferred type information and by dis… (Closed)

Created:
7 years, 8 months ago by kasperl
Modified:
7 years, 8 months ago
Reviewers:
vsm, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve optimization of operations on indexables by using more inferred type information and by disabling inlining of [], []= and length (still optimized but now in the folder). R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21946

Patch Set 1 #

Patch Set 2 : Update html.status. #

Patch Set 3 : Fix dartc warnings. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 3 chunks +24 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/types.dart View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_relations_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M tests/html/html.status View 1 1 chunk +0 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
kasperl
7 years, 8 months ago (2013-04-24 12:38:12 UTC) #1
ngeoffray
LGTM
7 years, 8 months ago (2013-04-24 12:55:01 UTC) #2
kasperl
Committed patchset #3 manually as r21946 (presubmit successful).
7 years, 8 months ago (2013-04-24 13:03:48 UTC) #3
vsm
https://codereview.chromium.org/14052009/diff/5001/tests/html/html.status File tests/html/html.status (left): https://codereview.chromium.org/14052009/diff/5001/tests/html/html.status#oldcode23 tests/html/html.status:23: typed_arrays_range_checks_test: Fail # TODO(vsm): Implement range checks. Kasper - ...
7 years, 8 months ago (2013-04-25 00:07:08 UTC) #4
kasperl
7 years, 8 months ago (2013-04-25 05:24:31 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/14052009/diff/5001/tests/html/html.status
File tests/html/html.status (left):

https://codereview.chromium.org/14052009/diff/5001/tests/html/html.status#old...
tests/html/html.status:23: typed_arrays_range_checks_test: Fail # TODO(vsm):
Implement range checks.
On 2013/04/25 00:07:08, vsm wrote:
> Kasper - I was just looking into adding explicit bounds checks here.  Are they
> no longer needed?  Looks like you're special casing the typed lists now.

There's still more to do. What I added in this CL gives us index bounds checks
for typed data lists whenever we optimize the access to them -- if we have too
little type information available to us to optimize the access, we will still
call the [] and []= operators on the typed lists.

It's a little bit weird, but we now have index checks in the optimized case -
and no such checks in the unoptimized case.

Powered by Google App Engine
This is Rietveld 408576698