sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart - Issue 14052009: Improve optimization of operations on indexables by using more inferred type information and by dis…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

Issue 14052009: Improve optimization of operations on indexables by using more inferred type information and by dis… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix dartc warnings. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/optimize.dart » ('j') | tests/html/html.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart b/sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

index 74e40bfc0f003ddef0fad3d6bd98c53605f25968..9d78bfdc9c38d645641c9cf61c6bed8d4da731f6 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart

@@ -130,8 +130,11 @@ class IndexSpecializer extends InvokeDynamicSpecializer {

HInstruction tryConvertToBuiltin(HInvokeDynamic instruction,

Compiler compiler) {

if (instruction.inputs[1].isIndexable(compiler)) {

- return new HIndex(

+ HInstruction index = new HIndex(

instruction.inputs[1], instruction.inputs[2], instruction.selector);

+ index.instructionType =

+ new HType.inferredTypeForSelector(instruction.selector, compiler);

+ return index;

}

return null;

}