Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/tools/telemetry/telemetry/page/page.py

Issue 14048008: Revert 194220 "[Telemetry] Make page cyclers more telemetric." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/perf/perf_tools/page_cycler.py ('k') | trunk/src/tools/telemetry/telemetry/page/page_benchmark_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/telemetry/telemetry/page/page.py
===================================================================
--- trunk/src/tools/telemetry/telemetry/page/page.py (revision 194259)
+++ trunk/src/tools/telemetry/telemetry/page/page.py (working copy)
@@ -51,10 +51,10 @@
path = self.base_dir + parsed_url.netloc + parsed_url.path
- if hasattr(self.page_set, 'serving_dirs'):
- url_base_dir = os.path.commonprefix(self.page_set.serving_dirs)
+ if hasattr(self, 'serving_dirs'):
+ url_base_dir = os.path.commonprefix(self.serving_dirs)
base_path = self.base_dir + '/' + url_base_dir
- return ([self.base_dir + '/' + d for d in self.page_set.serving_dirs],
+ return ([self.base_dir + '/' + d for d in self.serving_dirs],
path.replace(base_path, ''))
return os.path.split(path)
« no previous file with comments | « trunk/src/tools/perf/perf_tools/page_cycler.py ('k') | trunk/src/tools/telemetry/telemetry/page/page_benchmark_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698