Image Filters: refactor all CPU input processing into a filterInput helper function.

Image Filters: refactor all CPU input processing into a filterInput helper function.

No change in behaviour; this is a straight refactoring.

BUG=skia:3194
Committed: https://skia.googlesource.com/skia/+/b9519f86bbce946e505980a4fa950fdc4bcf74ab

[Stephen White, 2015-10-15 17:18:48]

senorblanco@chromium.org changed reviewers:
+ reed@google.com

[Stephen White, 2015-10-15 17:18:56]

reed@: PTAL. Thanks!

[Stephen White, 2015-10-15 17:34:26]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-15 17:34:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404743005/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404743005/30001

[Stephen White, 2015-10-15 17:36:22]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-15 17:36:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404743005/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404743005/50001

[commit-bot: I haz the power, 2015-10-15 17:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 17:51:11]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-10-15 18:34:03]

not obvious to me my this CL is associated w/ that bug#, but no matter.

lgtm w/ comment about the comment.

https://codereview.chromium.org/1404743005/diff/50001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1404743005/diff/50001/include/core/SkImageFil...
include/core/SkImageFilter.h:340: // Non-virtual helper function which filters
the given input.
At the first 2-3 reads, I did not understand what "given input" meant, since
none of the parameters are named input.

I see now that you mean "the input filter at the specified index", but perhaps
the comment could make that clearer.
It could possibly have pseudo code that shows the gist of the impl, to make it
clear...

return !getInput(index) || getInput(index->filterImage(...);

[reed1, 2015-10-15 18:34:29]

s/my/why

[Stephen White, 2015-10-15 19:03:32]

On 2015/10/15 18:34:03, reed1 wrote:
> not obvious to me my this CL is associated w/ that bug#, but no matter.

I plan to add some more functionality to filterInput() to help fix that bug.

> lgtm w/ comment about the comment.
> 
>
https://codereview.chromium.org/1404743005/diff/50001/include/core/SkImageFil...
> File include/core/SkImageFilter.h (right):
> 
>
https://codereview.chromium.org/1404743005/diff/50001/include/core/SkImageFil...
> include/core/SkImageFilter.h:340: // Non-virtual helper function which filters
> the given input.
> At the first 2-3 reads, I did not understand what "given input" meant, since
> none of the parameters are named input.
> 
> I see now that you mean "the input filter at the specified index", but perhaps
> the comment could make that clearer.
> It could possibly have pseudo code that shows the gist of the impl, to make it
> clear...
> 
> return !getInput(index) || getInput(index->filterImage(...);

[Stephen White, 2015-10-15 19:03:40]

https://codereview.chromium.org/1404743005/diff/50001/include/core/SkImageFil...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1404743005/diff/50001/include/core/SkImageFil...
include/core/SkImageFilter.h:340: // Non-virtual helper function which filters
the given input.
On 2015/10/15 18:34:03, reed1 wrote:
> At the first 2-3 reads, I did not understand what "given input" meant, since
> none of the parameters are named input.
> 
> I see now that you mean "the input filter at the specified index", but perhaps
> the comment could make that clearer.
> It could possibly have pseudo code that shows the gist of the impl, to make it
> clear...
> 
> return !getInput(index) || getInput(index->filterImage(...);

Done.

[Stephen White, 2015-10-15 19:04:13]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-15 19:04:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404743005/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404743005/70001

[commit-bot: I haz the power, 2015-10-15 19:14:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 19:14:00]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2015-10-15 19:14:17]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2015-10-15 19:14:17]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1404743005/#ps70001
(title: "Tweak comment")

[commit-bot: I haz the power, 2015-10-15 19:14:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404743005/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404743005/70001

[commit-bot: I haz the power, 2015-10-15 19:15:17]

Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/b9519f86bbce946e505980a4fa950fdc4bcf74ab