src/effects/SkDropShadowImageFilter.cpp - Issue 1404743005: Image Filters: refactor all CPU input processing into a filterInput helper function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDropShadowImageFilter.cpp

Issue 1404743005: Image Filters: refactor all CPU input processing into a filterInput helper function. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Tweak comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkDropShadowImageFilter.cpp

diff --git a/src/effects/SkDropShadowImageFilter.cpp b/src/effects/SkDropShadowImageFilter.cpp

index c856bd17e883cc6d0992c2dbe2984cda4cb0be63..7519d5313d08f956206aff541493bbdb2225fa38 100644

--- a/src/effects/SkDropShadowImageFilter.cpp

+++ b/src/effects/SkDropShadowImageFilter.cpp

@@ -59,7 +59,7 @@ bool SkDropShadowImageFilter::onFilterImage(Proxy* proxy, const SkBitmap& source

{

SkBitmap src = source;

SkIPoint srcOffset = SkIPoint::Make(0, 0);

- if (getInput(0) && !getInput(0)->filterImage(proxy, source, ctx, &src, &srcOffset))

+ if (!this->filterInput(0, proxy, source, ctx, &src, &srcOffset))

return false;

SkIRect bounds;

« no previous file with comments | « src/effects/SkDisplacementMapEffect.cpp ('k') | src/effects/SkLightingImageFilter.cpp » ('j') | no next file with comments »