Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 1404743005: Image Filters: refactor all CPU input processing into a filterInput helper function. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Tweak comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/effects/SkDropShadowImageFilter.cpp ('k') | src/effects/SkMatrixConvolutionImageFilter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/effects/SkLightingImageFilter.cpp
diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp
index 32589e1826c8aee778a0bb8cac730e6f38b17348..161d0ec17c6fdcd3a57d596fea1db233c4e56282 100644
--- a/src/effects/SkLightingImageFilter.cpp
+++ b/src/effects/SkLightingImageFilter.cpp
@@ -1172,10 +1172,9 @@ bool SkDiffuseLightingImageFilter::onFilterImage(Proxy* proxy,
const Context& ctx,
SkBitmap* dst,
SkIPoint* offset) const {
- SkImageFilter* input = getInput(0);
SkBitmap src = source;
SkIPoint srcOffset = SkIPoint::Make(0, 0);
- if (input && !input->filterImage(proxy, source, ctx, &src, &srcOffset)) {
+ if (!this->filterInput(0, proxy, source, ctx, &src, &srcOffset)) {
return false;
}
@@ -1313,10 +1312,9 @@ bool SkSpecularLightingImageFilter::onFilterImage(Proxy* proxy,
const Context& ctx,
SkBitmap* dst,
SkIPoint* offset) const {
- SkImageFilter* input = getInput(0);
SkBitmap src = source;
SkIPoint srcOffset = SkIPoint::Make(0, 0);
- if (input && !input->filterImage(proxy, source, ctx, &src, &srcOffset)) {
+ if (!this->filterInput(0, proxy, source, ctx, &src, &srcOffset)) {
return false;
}
« no previous file with comments | « src/effects/SkDropShadowImageFilter.cpp ('k') | src/effects/SkMatrixConvolutionImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698