Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1404593002: Extract i18n behavior from settings. (Closed)

Created:
5 years, 2 months ago by fhorschig
Modified:
5 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dschuyler
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract i18n behavior from settings. The i18n behavior previously defined for md-settings seems to be usefull for other CLs (e.g. https://codereview.chromium.org/1371073003/). Therefore, it is moved to resources/{js,html}. BUG=134849 Committed: https://crrev.com/9a63e1a18a28fa065085c359c323c8887f0d38ed Cr-Commit-Position: refs/heads/master@{#354464}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove polymer_ prefix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -36 lines) Patch
M chrome/browser/resources/settings/default_browser_page/default_browser_page.html View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/settings/i18n_behavior/i18n_behavior.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/settings/i18n_behavior/i18n_behavior.js View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +0 lines, -6 lines 0 comments Download
A ui/webui/resources/html/i18n_behavior.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A + ui/webui/resources/js/i18n_behavior.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
fhorschig
Hi Dan, would you please have a short look on the extraction of the I18nBehavior ...
5 years, 2 months ago (2015-10-13 10:08:45 UTC) #3
fhorschig
CC'ed dschuyler@ as original author of this class in case he is interested in this ...
5 years, 2 months ago (2015-10-13 10:09:48 UTC) #4
Dan Beam
https://codereview.chromium.org/1404593002/diff/20001/chrome/browser/resources/settings/default_browser_page/default_browser_page.html File chrome/browser/resources/settings/default_browser_page/default_browser_page.html (right): https://codereview.chromium.org/1404593002/diff/20001/chrome/browser/resources/settings/default_browser_page/default_browser_page.html#newcode4 chrome/browser/resources/settings/default_browser_page/default_browser_page.html:4: <link rel="import" href="chrome://resources/html/polymer_i18n_behavior.html"> why polymer_?
5 years, 2 months ago (2015-10-15 03:45:43 UTC) #5
fhorschig
https://codereview.chromium.org/1404593002/diff/20001/chrome/browser/resources/settings/default_browser_page/default_browser_page.html File chrome/browser/resources/settings/default_browser_page/default_browser_page.html (right): https://codereview.chromium.org/1404593002/diff/20001/chrome/browser/resources/settings/default_browser_page/default_browser_page.html#newcode4 chrome/browser/resources/settings/default_browser_page/default_browser_page.html:4: <link rel="import" href="chrome://resources/html/polymer_i18n_behavior.html"> On 2015/10/15 03:45:43, Dan Beam wrote: ...
5 years, 2 months ago (2015-10-15 15:10:35 UTC) #6
Dan Beam
lgtm
5 years, 2 months ago (2015-10-15 16:50:05 UTC) #8
stevenjb
On 2015/10/15 16:50:05, Dan Beam wrote: > lgtm I would definitely prefer to see the ...
5 years, 2 months ago (2015-10-15 21:33:16 UTC) #9
stevenjb
On 2015/10/15 21:33:16, stevenjb wrote: > On 2015/10/15 16:50:05, Dan Beam wrote: > > lgtm ...
5 years, 2 months ago (2015-10-15 22:04:22 UTC) #10
Dan Beam
On 2015/10/15 22:04:22, stevenjb wrote: > On 2015/10/15 21:33:16, stevenjb wrote: > > On 2015/10/15 ...
5 years, 2 months ago (2015-10-16 01:20:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404593002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404593002/60001
5 years, 2 months ago (2015-10-16 06:41:01 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 2 months ago (2015-10-16 07:39:30 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 07:40:14 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a63e1a18a28fa065085c359c323c8887f0d38ed
Cr-Commit-Position: refs/heads/master@{#354464}

Powered by Google App Engine
This is Rietveld 408576698