Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1406023003: Elim cr_elements/v1_0 subdirectory (Closed)

Created:
5 years, 2 months ago by stevenjb
Modified:
5 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, Jeremy Klein, michaelpg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Elim cr_elements/v1_0 subdirectory This removes the now redundant v1_0 subdirectory from cr_elements/ BUG=489785 Committed: https://crrev.com/f18c56b347b7deebbc50d4eb2363cfcbd2fd229f Cr-Commit-Position: refs/heads/master@{#354560}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -2540 lines) Patch
M chrome/browser/resources/chromeos/network_ui/compiled_resources.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/network_ui/network_ui.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_downloads/compiled_resources.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_extensions/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_extensions/toolbar.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/compiled_resources.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/controls/compiled_resources.gyp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/compiled_resources.gyp View 13 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_known_networks_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_apnlist.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_ip_config.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_nameservers.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_property_list.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_siminfo.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/compiled_resources.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/languages_page/language_detail_page.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_adder.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + ui/webui/resources/cr_elements/compiled_resources.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_collapse/cr_collapse.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_collapse/cr_collapse.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_collapse/cr_collapse.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_collapse/demo.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_collapse/demo.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_events/cr_events.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_events/cr_events.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_search_field/cr_search_field.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/cr_search_field/cr_search_field.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/demo_config.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/demo_element.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/demo_element.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/webui/resources/cr_elements/demo_element.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/demo_page.html View 1 chunk +1 line, -1 line 0 comments Download
A + ui/webui/resources/cr_elements/network/compiled_resources.gyp View 2 chunks +7 lines, -7 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_icon.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_icon.html View 1 chunk +1 line, -1 line 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_icon.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_icon_externs.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_list.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_list.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_list.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_list_item.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_list_item.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_list_item.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_select.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_select.html View 1 chunk +4 lines, -4 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_network_select.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_onc_types.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/network/cr_onc_types.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/policy/compiled_resources.gyp View 1 2 chunks +9 lines, -10 lines 0 comments Download
A + ui/webui/resources/cr_elements/policy/cr_policy_indicator.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/policy/cr_policy_pref_behavior.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/policy/cr_policy_pref_behavior.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/compiled_resources.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_collapse/cr_collapse.css View 1 chunk +0 lines, -7 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_collapse/cr_collapse.html View 1 chunk +0 lines, -11 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_collapse/cr_collapse.js View 1 chunk +0 lines, -53 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_collapse/demo.html View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_collapse/demo.js View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_events/cr_events.html View 1 chunk +0 lines, -5 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_events/cr_events.js View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_expand_button/cr_expand_button.css View 1 chunk +0 lines, -7 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_expand_button/cr_expand_button.html View 1 chunk +0 lines, -14 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_expand_button/cr_expand_button.js View 1 chunk +0 lines, -44 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_search_field/cr_search_field.css View 1 chunk +0 lines, -71 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_search_field/cr_search_field.html View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/cr_search_field/cr_search_field.js View 1 chunk +0 lines, -75 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/demo_config.js View 1 chunk +0 lines, -5 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/demo_element.css View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/demo_element.html View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/demo_element.js View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/demo_page.html View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/compiled_resources.gyp View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_icon.css View 1 chunk +0 lines, -80 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_icon.html View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_icon.js View 1 chunk +0 lines, -294 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_icon_externs.js View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_list.css View 1 1 chunk +0 lines, -18 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_list.html View 1 chunk +0 lines, -21 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_list.js View 1 chunk +0 lines, -75 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.css View 1 chunk +0 lines, -77 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.html View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_list_item.js View 1 chunk +0 lines, -221 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_select.css View 1 chunk +0 lines, -7 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_select.html View 1 chunk +0 lines, -27 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_network_select.js View 1 chunk +0 lines, -154 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_onc_types.html View 1 chunk +0 lines, -1 line 0 comments Download
D ui/webui/resources/cr_elements/v1_0/network/cr_onc_types.js View 1 chunk +0 lines, -469 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/policy/compiled_resources.gyp View 1 1 chunk +0 lines, -48 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/policy/cr_policy_indicator.css View 1 chunk +0 lines, -11 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/policy/cr_policy_indicator_behavior.html View 1 1 chunk +0 lines, -1 line 0 comments Download
D ui/webui/resources/cr_elements/v1_0/policy/cr_policy_indicator_behavior.js View 1 1 chunk +0 lines, -89 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_behavior.html View 1 1 chunk +0 lines, -1 line 0 comments Download
D ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_behavior.js View 1 1 chunk +0 lines, -45 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_indicator.html View 1 1 chunk +0 lines, -20 lines 0 comments Download
D ui/webui/resources/cr_elements/v1_0/policy/cr_policy_pref_indicator.js View 1 1 chunk +0 lines, -59 lines 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 1 chunk +74 lines, -74 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (3 generated)
stevenjb
This is entirely mechanical and long overdue. No complaints from the closure compiler and md-settings ...
5 years, 2 months ago (2015-10-15 22:02:40 UTC) #2
stevenjb
cc: jlklein@ and michaelpg@ I will email out a PSA to chromium-polymer@ before committing.
5 years, 2 months ago (2015-10-15 22:04:03 UTC) #3
Dan Beam
assuming we have no concrete plans to use other polymer versions, lgtm
5 years, 2 months ago (2015-10-15 23:11:14 UTC) #4
Dan Beam
(fwiw: I didn't review, just stamped)
5 years, 2 months ago (2015-10-15 23:11:26 UTC) #5
stevenjb
On 2015/10/15 23:11:14, Dan Beam wrote: > assuming we have no concrete plans to use ...
5 years, 2 months ago (2015-10-15 23:15:26 UTC) #6
stevenjb
Waiting for https://codereview.chromium.org/1391433003/ to land then will rebase, send a PSA, and CQ.
5 years, 2 months ago (2015-10-15 23:16:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406023003/20001
5 years, 2 months ago (2015-10-16 18:13:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-16 19:28:15 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 19:29:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f18c56b347b7deebbc50d4eb2363cfcbd2fd229f
Cr-Commit-Position: refs/heads/master@{#354560}

Powered by Google App Engine
This is Rietveld 408576698