Do high-quality resizes for notification images.

Do high-quality resizes for notification images.

Use gfx::ImageSkiaOperations::CreateResizedImage() with
RESIZE_BEST when resizing notification images to 80x80
before painting them.

Previously, gfx::Canvas::DrawImageInt() was used, but this
results in poor results with some large images.

BUG=543658
Committed: https://crrev.com/ac4ebe021dd185d7a86e930a623891619a415f1d
Cr-Commit-Position: refs/heads/master@{#354310}

[Daniel Erat, 2015-10-15 17:14:24]

derat@chromium.org changed reviewers:
+ dewittj@chromium.org

[Daniel Erat, 2015-10-15 17:14:25]

https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
File ui/message_center/views/proportional_image_view.cc (left):

https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
ui/message_center/views/proportional_image_view.cc:49:
paint.setFilterQuality(kLow_SkFilterQuality);
i saw no changes when increasing the filter quality here.

https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
File ui/message_center/views/proportional_image_view.cc (right):

https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
ui/message_center/views/proportional_image_view.cc:47: image_,
skia::ImageOperations::RESIZE_BEST, draw_size);
i'm hopeful that there aren't any performance concerns with doing this. i only
see OnPaint() called a single time, when the notification is first displayed.

at the cost of increased memory usage, i could cache the resized image in this
class so it can be reused if OnPaint() is called again later with a canvas of
the same dimensions. (i'd rather not throw out the original image in case the
class ever needs to redraw at a larger size.)

[Daniel Erat, 2015-10-15 17:14:39]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-15 17:15:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404333002/1

[dewittj, 2015-10-15 17:18:57]

lgtm

Thanks for the contribution!

https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
File ui/message_center/views/proportional_image_view.cc (left):

https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
ui/message_center/views/proportional_image_view.cc:49:
paint.setFilterQuality(kLow_SkFilterQuality);
On 2015/10/15 17:14:25, Daniel Erat wrote:
> i saw no changes when increasing the filter quality here.

Acknowledged.

https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
File ui/message_center/views/proportional_image_view.cc (right):

https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
ui/message_center/views/proportional_image_view.cc:47: image_,
skia::ImageOperations::RESIZE_BEST, draw_size);
On 2015/10/15 17:14:25, Daniel Erat wrote:
> i'm hopeful that there aren't any performance concerns with doing this. i only
> see OnPaint() called a single time, when the notification is first displayed.
> 
> at the cost of increased memory usage, i could cache the resized image in this
> class so it can be reused if OnPaint() is called again later with a canvas of
> the same dimensions. (i'd rather not throw out the original image in case the
> class ever needs to redraw at a larger size.)

Seems unlikely that paint performance will be a problem for such a transient
view.  I'm inclined just to leave the code simple.

[Daniel Erat, 2015-10-15 17:20:19]

On 2015/10/15 17:18:57, dewittj wrote:
> lgtm
> 
> Thanks for the contribution!
> 
>
https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
> File ui/message_center/views/proportional_image_view.cc (left):
> 
>
https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
> ui/message_center/views/proportional_image_view.cc:49:
> paint.setFilterQuality(kLow_SkFilterQuality);
> On 2015/10/15 17:14:25, Daniel Erat wrote:
> > i saw no changes when increasing the filter quality here.
> 
> Acknowledged.
> 
>
https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
> File ui/message_center/views/proportional_image_view.cc (right):
> 
>
https://codereview.chromium.org/1404333002/diff/1/ui/message_center/views/pro...
> ui/message_center/views/proportional_image_view.cc:47: image_,
> skia::ImageOperations::RESIZE_BEST, draw_size);
> On 2015/10/15 17:14:25, Daniel Erat wrote:
> > i'm hopeful that there aren't any performance concerns with doing this. i
only
> > see OnPaint() called a single time, when the notification is first
displayed.
> > 
> > at the cost of increased memory usage, i could cache the resized image in
this
> > class so it can be reused if OnPaint() is called again later with a canvas
of
> > the same dimensions. (i'd rather not throw out the original image in case
the
> > class ever needs to redraw at a larger size.)
> 
> Seems unlikely that paint performance will be a problem for such a transient
> view.  I'm inclined just to leave the code simple.

great, thanks for the quick review!

[Daniel Erat, 2015-10-15 17:20:31]

The CQ bit was unchecked by derat@chromium.org

[Daniel Erat, 2015-10-15 17:20:35]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2015-10-15 17:20:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404333002/1

[commit-bot: I haz the power, 2015-10-15 18:28:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-15 18:29:42]

Patchset 1 (id:??) landed as
https://crrev.com/ac4ebe021dd185d7a86e930a623891619a415f1d
Cr-Commit-Position: refs/heads/master@{#354310}