Do high-quality resizes for notification images.

ui/message_center/views/proportional_image_view.cc

Index: ui/message_center/views/proportional_image_view.cc
diff --git a/ui/message_center/views/proportional_image_view.cc b/ui/message_center/views/proportional_image_view.cc
index 217832436df767cf599b9dd588160c4ededbd9f7..a7befd66fb2090e2264a2ba936ee5857ab46b47d 100644
--- a/ui/message_center/views/proportional_image_view.cc
+++ b/ui/message_center/views/proportional_image_view.cc
@@ -5,6 +5,7 @@
 #include "ui/message_center/views/proportional_image_view.h"
 
 #include "ui/gfx/canvas.h"
+#include "ui/gfx/image/image_skia_operations.h"
 #include "ui/message_center/message_center_style.h"
 
 namespace message_center {
@@ -33,29 +34,18 @@ void ProportionalImageView::OnPaint(gfx::Canvas* canvas) {
   views::View::OnPaint(canvas);
 
   gfx::Size draw_size = GetImageDrawingSize();
-
   if (draw_size.IsEmpty())
     return;
 
   gfx::Rect draw_bounds = GetContentsBounds();
   draw_bounds.ClampToCenteredSize(draw_size);
 
-  gfx::Size image_size(image_.size());
-
-  if (image_size == draw_size) {
-    canvas->DrawImageInt(image_, draw_bounds.x(), draw_bounds.y());
-  } else {
-    SkPaint paint;
-    paint.setFilterQuality(kLow_SkFilterQuality);

[Daniel Erat, 2015/10/15 17:14:25]

i saw no changes when increasing the filter quality here.

[dewittj, 2015/10/15 17:18:56]

Acknowledged.

-
-    // This call resizes the image while drawing into the canvas.
-    canvas->DrawImageInt(
-        image_,
-        0, 0, image_size.width(), image_size.height(),
-        draw_bounds.x(), draw_bounds.y(), draw_size.width(), draw_size.height(),
-        true,
-        paint);
-  }
+  gfx::ImageSkia image =
+      (image_.size() == draw_size)
+          ? image_
+          : gfx::ImageSkiaOperations::CreateResizedImage(
+                image_, skia::ImageOperations::RESIZE_BEST, draw_size);

[Daniel Erat, 2015/10/15 17:14:25]

i'm hopeful that there aren't any performance concerns with doing this. i only
see OnPaint() called a single time, when the notification is first displayed.

at the cost of increased memory usage, i could cache the resized image in this
class so it can be reused if OnPaint() is called again later with a canvas of
the same dimensions. (i'd rather not throw out the original image in case the
class ever needs to redraw at a larger size.)

[dewittj, 2015/10/15 17:18:56]

Seems unlikely that paint performance will be a problem for such a transient
view.  I'm inclined just to leave the code simple.

+  canvas->DrawImageInt(image, draw_bounds.x(), draw_bounds.y());
 }
 
 const char* ProportionalImageView::GetClassName() const {