Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1404163003: ServiceWorker: Remove unnecessary accessors for uncommitted/purgeable resources (Closed)

Created:
5 years, 2 months ago by nhiroki
Modified:
5 years, 2 months ago
Reviewers:
falken, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Remove unnecessary accessors for uncommitted/purgeable resources This is a refactoring CL. Resources managed by service worker should belong to one of following lists for their whole lifetime: uncommitted, committed and purgeable. They are allowed to move among the lists as following rules: 1. <new> -> uncommitted -> committed -> purgeable -> <doomed> 2. <new> -> uncommitted -> purgeable -> <doomed> To strictly obey the rules, this CL... - removes ClearUncommittedResourceIds(). Uncommitted resources to be doomed should be moved into the purgeable list rather than directly removed from the uncommitted list. - removes WritePurgeableResourceIds(). Resources to be doomed should not be directly written in the purgeable list. They should be moved from the uncommitted or committed list. BUG=485900 Committed: https://crrev.com/fb707420e296d3d594aef9ecb5d787b995ee5e55 Cr-Commit-Position: refs/heads/master@{#354237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -103 lines) Patch
M content/browser/service_worker/service_worker_database.h View 3 chunks +14 lines, -25 lines 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 4 chunks +12 lines, -32 lines 0 comments Download
M content/browser/service_worker/service_worker_database_unittest.cc View 3 chunks +13 lines, -46 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nhiroki
PTAL, thanks!
5 years, 2 months ago (2015-10-15 05:05:59 UTC) #2
falken
lgtm
5 years, 2 months ago (2015-10-15 05:27:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404163003/1
5 years, 2 months ago (2015-10-15 05:31:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/117354)
5 years, 2 months ago (2015-10-15 06:54:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404163003/1
5 years, 2 months ago (2015-10-15 07:02:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 08:01:09 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 08:01:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb707420e296d3d594aef9ecb5d787b995ee5e55
Cr-Commit-Position: refs/heads/master@{#354237}

Powered by Google App Engine
This is Rietveld 408576698