ServiceWorker: Remove unnecessary accessors for uncommitted/purgeable resources

content/browser/service_worker/service_worker_database.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DATABASE_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DATABASE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 182 matching lines @@
   // database.
   Status DeleteUserData(int64 registration_id,
                         const std::string& user_data_name);
 
   // Reads user data for all registrations that have data with |user_data_name|
   // from the database. Returns OK if they are successfully read or not found.
   Status ReadUserDataForAllRegistrations(
       const std::string& user_data_name,
       std::vector<std::pair<int64, std::string>>* user_data);
 
-  // As new resources are put into the diskcache, they go into an uncommitted
-  // list. When a registration is saved that refers to those ids, they're
-  // removed from that list. When a resource no longer has any registrations or
+  // Resources should belong to one of following resource lists: uncommitted,
+  // committed and purgeable.
+  // As new resources are put into the diskcache, they go into the uncommitted
+  // list. When a registration is saved that refers to those ids, they're moved
+  // to the committed list. When a resource no longer has any registrations or
   // caches referring to it, it's added to the purgeable list. Periodically,
   // the purgeable list can be purged from the diskcache. At system startup, all
   // uncommitted ids are moved to the purgeable list.
 
-  // Reads uncommitted resource ids from the database. Returns OK on success.
+  // Reads resource ids from the uncommitted list. Returns OK on success.
   // Otherwise clears |ids| and returns an error.
   Status GetUncommittedResourceIds(std::set<int64>* ids);
 
-  // Writes |ids| into the database as uncommitted resources. Returns OK on
-  // success. Otherwise writes nothing and returns an error.
+  // Writes resource ids into the uncommitted list. Returns OK on success.
+  // Otherwise writes nothing and returns an error.
   Status WriteUncommittedResourceIds(const std::set<int64>& ids);
 
-  // Deletes uncommitted resource ids specified by |ids| from the database.
-  // Returns OK on success. Otherwise deletes nothing and returns an error.
-  Status ClearUncommittedResourceIds(const std::set<int64>& ids);
-
-  // Reads purgeable resource ids from the database. Returns OK on success.
+  // Reads resource ids from the purgeable list. Returns OK on success.
   // Otherwise clears |ids| and returns an error.
   Status GetPurgeableResourceIds(std::set<int64>* ids);
 
-  // Writes |ids| into the database as purgeable resources. Returns OK on
-  // success. Otherwise writes nothing and returns an error.
-  Status WritePurgeableResourceIds(const std::set<int64>& ids);
-
-  // Deletes purgeable resource ids specified by |ids| from the database.
-  // Returns OK on success. Otherwise deletes nothing and returns an error.
+  // Deletes resource ids from the purgeable list. Returns OK on success.
+  // Otherwise deletes nothing and returns an error.
   Status ClearPurgeableResourceIds(const std::set<int64>& ids);
 
-  // Moves |ids| from the uncommitted list to the purgeable list.
-  // Returns OK on success. Otherwise deletes nothing and returns an error.
+  // Writes resource ids into the purgeable list and removes them from the
+  // uncommitted list. Returns OK on success. Otherwise writes nothing and
+  // returns an error.
   Status PurgeUncommittedResourceIds(const std::set<int64>& ids);
 
   // Deletes all data for |origins|, namely, unique origin, registrations and
   // resource records. Resources are moved to the purgeable list. Returns OK if
   // they are successfully deleted or not found in the database. Otherwise,
   // returns an error.
   Status DeleteAllDataForOrigins(const std::set<GURL>& origins,
                                  std::vector<int64>* newly_purgeable_resources);
 
   // Completely deletes the contents of the database.
@@ skipping 47 matching lines @@
 
   // Reads resource ids for |id_key_prefix| from the database. Returns OK if
   // it's successfully read or not found in the database. Otherwise, returns an
   // error.
   Status ReadResourceIds(
       const char* id_key_prefix,
       std::set<int64>* ids);
 
   // Write resource ids for |id_key_prefix| into the database. Returns OK on
   // success. Otherwise, returns writes nothing and returns an error.
-  Status WriteResourceIds(
-      const char* id_key_prefix,
-      const std::set<int64>& ids);
   Status WriteResourceIdsInBatch(
       const char* id_key_prefix,
       const std::set<int64>& ids,
       leveldb::WriteBatch* batch);
 
   // Deletes resource ids for |id_key_prefix| from the database. Returns OK if
   // it's successfully deleted or not found in the database. Otherwise, returns
   // an error.
-  Status DeleteResourceIds(
-      const char* id_key_prefix,
-      const std::set<int64>& ids);
   Status DeleteResourceIdsInBatch(
       const char* id_key_prefix,
       const std::set<int64>& ids,
       leveldb::WriteBatch* batch);
 
   // Deletes all user data for |registration_id| from the database. Returns OK
   // if they are successfully deleted or not found in the database.
   Status DeleteUserDataForRegistration(
       int64 registration_id,
       leveldb::WriteBatch* batch);
@@ skipping 73 matching lines @@
                            MigrateOnDiskCacheAccess);
   FRIEND_TEST_ALL_PREFIXES(ServiceWorkerDiskCacheMigratorTest,
                            NotMigrateOnDatabaseAccess);
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerDatabase);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DATABASE_H_