Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404093003: [turbofan] Negate with shifted input for ARM64 (Closed)

Created:
5 years, 2 months ago by martyn.capewell
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Negate with shifted input for ARM64 Support negate with shifted input on ARM64 by supporting lhs zero registers for binary operations, and removing explicit Neg instruction support. Committed: https://crrev.com/a456134b8b7f33187f1725c1d1d0e7581c9e0ab8 Cr-Commit-Position: refs/heads/master@{#31263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -47 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 4 chunks +52 lines, -26 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M src/compiler/code-generator-impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 3 chunks +64 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
martyn.capewell
5 years, 2 months ago (2015-10-14 13:19:45 UTC) #2
Benedikt Meurer
Nice! LGTM
5 years, 2 months ago (2015-10-14 13:35:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404093003/1
5 years, 2 months ago (2015-10-14 14:05:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 14:50:51 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 14:51:20 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a456134b8b7f33187f1725c1d1d0e7581c9e0ab8
Cr-Commit-Position: refs/heads/master@{#31263}

Powered by Google App Engine
This is Rietveld 408576698