bluetooth: Implement BluetoothCharacteristicProperties

bluetooth: Implement BluetoothCharacteristicProperties

https://webbluetoothcg.github.io/web-bluetooth/#bluetoothcharacteristicproperties

BUG=483345
Committed: https://crrev.com/9a72f7ca718dd0614db12f89b14044e62d6e2442
Cr-Commit-Position: refs/heads/master@{#355218}

[ortuno, 2015-10-19 21:52:18]

Description was changed from

==========
Working characteristic properties

BUG=
==========

to

==========
WIP characteristic properties

BUG=
==========

[ortuno, 2015-10-19 22:33:12]

Description was changed from

==========
WIP characteristic properties

BUG=
==========

to

==========
bluetooth: Implement BluetoothCharacteristicProperties

https://webbluetoothcg.github.io/web-bluetooth/#bluetoothcharacteristicproper...

BUG=483345
==========

[ortuno, 2015-10-20 17:59:34]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 17:59:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403723004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403723004/80001

[ortuno, 2015-10-20 18:00:50]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2015-10-20 18:00:51]

scheib: PTAL

[commit-bot: I haz the power, 2015-10-20 18:20:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 18:21:02]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scheib, 2015-10-20 19:50:35]

LGTM

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.cpp
(right):

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.cpp:28:
if (properties & static_cast<uint32_t>(Property::BROADCAST))
The 'enum class' vs 'enum' is requiring you to add typecasting. Optionally just
remove the 'class' and take out the static_casts.

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.h
(right):

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.h:16:

Remove blank line

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.h:53:
bool m_broadcast;
Store the single uint32_t 'properties' (4 bytes) and in the accessors do the bit
mask and conversion to bool. No need for the 9 bool members (12 bytes due to
padding).

[ortuno, 2015-10-20 23:32:51]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 23:33:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403723004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403723004/100001

[ortuno, 2015-10-20 23:33:24]

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.cpp
(right):

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.cpp:28:
if (properties & static_cast<uint32_t>(Property::BROADCAST))
On 2015/10/20 at 19:50:35, scheib wrote:
> The 'enum class' vs 'enum' is requiring you to add typecasting. Optionally
just remove the 'class' and take out the static_casts.

Done.

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.h
(right):

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.h:16:

On 2015/10/20 at 19:50:35, scheib wrote:
> Remove blank line

Done.

https://codereview.chromium.org/1403723004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.h:53:
bool m_broadcast;
On 2015/10/20 at 19:50:35, scheib wrote:
> Store the single uint32_t 'properties' (4 bytes) and in the accessors do the
bit mask and conversion to bool. No need for the 9 bool members (12 bytes due to
padding).

Done.

[ortuno, 2015-10-20 23:34:42]

ortuno@chromium.org changed reviewers:
+ palmer@chromium.org

[ortuno, 2015-10-20 23:34:43]

palmer: PTAL at content/common/bluetooth_messages.h

[palmer, 2015-10-21 00:15:53]

lgtm

[commit-bot: I haz the power, 2015-10-21 01:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 01:51:56]

Dry run: This issue passed the CQ dry run.

[ortuno, 2015-10-21 01:52:30]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-10-21 01:52:30]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1403723004/#ps100001
(title: "Address scheib's comments")

[commit-bot: I haz the power, 2015-10-21 01:52:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403723004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403723004/100001

[commit-bot: I haz the power, 2015-10-21 01:57:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-21 01:59:52]

Patchset 6 (id:??) landed as
https://crrev.com/9a72f7ca718dd0614db12f89b14044e62d6e2442
Cr-Commit-Position: refs/heads/master@{#355218}